Warning: Can't synchronize with repository "(default)" (/home/git/ome.git does not appear to be a Git repository.). Look in the Trac log for more information.

Ticket #12121: 0006-specification-Add-Visible-ROI-enum.patch

File 0006-specification-Add-Visible-ROI-enum.patch, 6.8 KB (added by rleigh, 10 years ago)
  • components/formats-api/src/loci/formats/meta/MetadataConverter.java

    From 69d7533fe994beed6429c33837cde6362b11aadd Mon Sep 17 00:00:00 2001
    From: Roger Leigh <r.leigh@dundee.ac.uk>
    Date: Sat, 19 Apr 2014 12:22:26 +0100
    Subject: [PATCH 6/7] specification: Add Visible ROI enum
    
    ---
     .../src/loci/formats/meta/MetadataConverter.java         | 16 ++++++++--------
     .../spec/schema/Schema2011_06_File_Upgrade_Test.java     |  7 ++++---
     .../specification/released-schema/2013-10-dev-2/ROI.xsd  | 10 ++++++++--
     3 files changed, 20 insertions(+), 13 deletions(-)
    
    diff --git a/components/formats-api/src/loci/formats/meta/MetadataConverter.java b/components/formats-api/src/loci/formats/meta/MetadataConverter.java
    index 456652f..c44c344 100644
    a b public final class MetadataConverter { 
    23462346          catch (NullPointerException e) { } 
    23472347 
    23482348          try { 
    2349             Boolean visible = src.getEllipseVisible(i, q); 
     2349            Visible visible = src.getEllipseVisible(i, q); 
    23502350            dest.setEllipseVisible(visible, i, q); 
    23512351          } 
    23522352          catch (NullPointerException e) { } 
    public final class MetadataConverter { 
    24752475          catch (NullPointerException e) { } 
    24762476 
    24772477          try { 
    2478             Boolean visible = src.getLabelVisible(i, q); 
     2478            Visible visible = src.getLabelVisible(i, q); 
    24792479            dest.setLabelVisible(visible, i, q); 
    24802480          } 
    24812481          catch (NullPointerException e) { } 
    public final class MetadataConverter { 
    25922592          catch (NullPointerException e) { } 
    25932593 
    25942594          try { 
    2595             Boolean visible = src.getLineVisible(i, q); 
     2595            Visible visible = src.getLineVisible(i, q); 
    25962596            dest.setLineVisible(visible, i, q); 
    25972597          } 
    25982598          catch (NullPointerException e) { } 
    public final class MetadataConverter { 
    27332733          catch (NullPointerException e) { } 
    27342734 
    27352735          try { 
    2736             Boolean visible = src.getMaskVisible(i, q); 
     2736            Visible visible = src.getMaskVisible(i, q); 
    27372737            dest.setMaskVisible(visible, i, q); 
    27382738          } 
    27392739          catch (NullPointerException e) { } 
    public final class MetadataConverter { 
    28622862          catch (NullPointerException e) { } 
    28632863 
    28642864          try { 
    2865             Boolean visible = src.getPointVisible(i, q); 
     2865            Visible visible = src.getPointVisible(i, q); 
    28662866            dest.setPointVisible(visible, i, q); 
    28672867          } 
    28682868          catch (NullPointerException e) { } 
    public final class MetadataConverter { 
    29792979          catch (NullPointerException e) { } 
    29802980 
    29812981          try { 
    2982             Boolean visible = src.getPolygonVisible(i, q); 
     2982            Visible visible = src.getPolygonVisible(i, q); 
    29832983            dest.setPolygonVisible(visible, i, q); 
    29842984          } 
    29852985          catch (NullPointerException e) { } 
    public final class MetadataConverter { 
    30903090          catch (NullPointerException e) { } 
    30913091 
    30923092          try { 
    3093             Boolean visible = src.getPolylineVisible(i, q); 
     3093            Visible visible = src.getPolylineVisible(i, q); 
    30943094            dest.setPolylineVisible(visible, i, q); 
    30953095          } 
    30963096          catch (NullPointerException e) { } 
    public final class MetadataConverter { 
    32133213          catch (NullPointerException e) { } 
    32143214 
    32153215          try { 
    3216             Boolean visible = src.getRectangleVisible(i, q); 
     3216            Visible visible = src.getRectangleVisible(i, q); 
    32173217            dest.setRectangleVisible(visible, i, q); 
    32183218          } 
    32193219          catch (NullPointerException e) { } 
  • components/formats-bsd/test/spec/schema/Schema2011_06_File_Upgrade_Test.java

    diff --git a/components/formats-bsd/test/spec/schema/Schema2011_06_File_Upgrade_Test.java b/components/formats-bsd/test/spec/schema/Schema2011_06_File_Upgrade_Test.java
    index 1c5e636..65217d7 100644
    a b import loci.common.services.ServiceFactory; 
    4545import loci.common.xml.XMLTools; 
    4646import loci.formats.services.OMEXMLService; 
    4747 
     48import ome.xml.model.enums.Visible; 
    4849import ome.xml.model.BinData; 
    4950import ome.xml.model.Channel; 
    5051import ome.xml.model.Dataset; 
    public class Schema2011_06_File_Upgrade_Test { 
    902903        Assert.assertEquals(Label.class.getName(), shape11.getClass().getName()); 
    903904        Label label11 = (Label) shape11; 
    904905        Assert.assertEquals(MESSAGE_REMOVED_PATH, label11.getText()); 
    905         Assert.assertFalse(label11.getVisible()); 
     906        Assert.assertFalse(label11.getVisible() != Visible.VISIBLE); 
    906907        Assert.assertEquals(Double.valueOf(0), label11.getX()); 
    907908        Assert.assertEquals(Double.valueOf(0), label11.getY()); 
    908909    } 
    public class Schema2011_06_File_Upgrade_Test { 
    914915        Assert.assertEquals(Label.class.getName(), shape12.getClass().getName()); 
    915916        Label label12 = (Label) shape12; 
    916917        Assert.assertEquals(MESSAGE_REMOVED_PATH, label12.getText()); 
    917         Assert.assertFalse(label12.getVisible()); 
     918        Assert.assertFalse(label12.getVisible() != Visible.VISIBLE); 
    918919        Assert.assertEquals(Double.valueOf(0), label12.getX()); 
    919920        Assert.assertEquals(Double.valueOf(0), label12.getY()); 
    920921    } 
    public class Schema2011_06_File_Upgrade_Test { 
    925926        Assert.assertEquals(Label.class.getName(), shape13.getClass().getName()); 
    926927        Label label13 = (Label) shape13; 
    927928        Assert.assertEquals(MESSAGE_REMOVED_PATH, label13.getText()); 
    928         Assert.assertFalse(label13.getVisible()); 
     929        Assert.assertFalse(label13.getVisible() != Visible.VISIBLE); 
    929930        Assert.assertEquals(Double.valueOf(0), label13.getX()); 
    930931        Assert.assertEquals(Double.valueOf(0), label13.getY()); 
    931932    } 
  • components/specification/released-schema/2013-10-dev-2/ROI.xsd

    diff --git a/components/specification/released-schema/2013-10-dev-2/ROI.xsd b/components/specification/released-schema/2013-10-dev-2/ROI.xsd
    index 8bca01b..ed7160c 100644
    a b  
    226226                                        </xsd:restriction> 
    227227                                </xsd:simpleType> 
    228228                        </xsd:attribute> 
    229                         <xsd:attribute name="Visible" use="optional" type="xsd:boolean"> 
     229                        <xsd:attribute name="Visible" use="optional"> 
    230230                                <xsd:annotation> 
    231231                                        <xsd:documentation> 
    232232                                                Controls whether the shape is currently visible, 
    233                                                 true is visible, false is hidden. 
     233                                                Visible is visible, Hidden is hidden. 
    234234                                        </xsd:documentation> 
    235235                                </xsd:annotation> 
     236                                <xsd:simpleType> 
     237                                        <xsd:restriction base="xsd:string"> 
     238                                                <xsd:enumeration value="Visible"/> 
     239                                                <xsd:enumeration value="Hidden"/> 
     240                                        </xsd:restriction> 
     241                                </xsd:simpleType> 
    236242                        </xsd:attribute> 
    237243 
    238244                        <xsd:attribute name="Locked" use="optional" type="xsd:boolean"> 

1.3.13-PRO © 2008-2011 Agilo Software all rights reserved (this page was served in: 0.29540 sec.)

We're Hiring!