Warning: Can't synchronize with repository "(default)" (/home/git/ome.git does not appear to be a Git repository.). Look in the Trac log for more information.
Notice: In order to edit this ticket you need to be either: a Product Owner, The owner or the reporter of the ticket, or, in case of a Task not yet assigned, a team_member"

Task #11684 (new)

Opened 10 years ago

Last modified 8 years ago

RFE: clarity about INI format

Reported by: mtbcarroll Owned by: jamoore
Priority: minor Milestone: Metadata
Component: Import Version: 4.4.9
Keywords: n.a. Cc: fs@…, crueden-x
Resources: n.a. Referenced By: n.a.
References: n.a. Remaining Time: n.a.
Sprint: n.a.

Description

ome.scifio.common.IniParser parses INI files but its comment handling seems to mess up lines with a # before the = as part of the "key" name and it also doesn't handle multi-line values as are found for, say, the Recording #1 Notes key for zeiss-lsm/sample files.mdb/sample files.mdb [XY-ch] as imported under OMERO 4.

If we need to handle keys with a '#' and values with multiple lines, some blank, and maybe even '=' in the values and whatnot, then we need to make sure that the original_metadata.txt file generator code writes these files out properly in the first place, in accordance with a documented INI format that IniParser properly reads, even the edge cases. (I assume some of this becomes moot in OMERO 5, but even that could probably be handling the metadata for "legacy" images better, those that were imported before the upgrade to OMERO 5, and in passing metadata to Python or something that may still need a string-based format.)

Also note that in OMERO 5 OriginalMetadataRequestI newly has its own simple INI parser to avoid the issue with '#' in keys.

Change History (3)

comment:1 Changed 10 years ago by mtbcarroll

#10304 describes some parsing problems.

comment:2 Changed 9 years ago by jamoore

  • Cc changed from fs@openmicroscopy.org.uk,crueden-x to fs@openmicroscopy.org.uk, crueden-x
  • Milestone changed from 5.1.0 to 5.x

Pushing.

comment:3 Changed 8 years ago by jamoore

  • Milestone changed from 5.x to Metadata
Note: See TracTickets for help on using tickets. You may also have a look at Agilo extensions to the ticket.

1.3.13-PRO © 2008-2011 Agilo Software all rights reserved (this page was served in: 0.64226 sec.)

We're Hiring!