Task #11938 (closed)
Opened 10 years ago
Closed 10 years ago
Treat web json properties as appendables
Reported by: | jamoore | Owned by: | aknab |
---|---|---|---|
Priority: | major | Milestone: | 5.0.0 |
Component: | Web | Version: | 5.0.0-rc1 |
Keywords: | n.a. | Cc: | web-team@…, cxallan, jburel, spli |
Resources: | n.a. | Referenced By: | n.a. |
References: | n.a. | Remaining Time: | n.a. |
Sprint: | n.a. |
Description (last modified by jamoore)
In order to prevent hard-coding values in OMERO.webapp setup, omeroweb should append values rather than overwriting:
- https://github.com/openmicroscopy/openmicroscopy/pull/1905 will add append/remove functions which treat config.xml strings as json lists
- settings.py will read the json lists but not overwrite the value
- Each append value from the json list will be appened IFF it does not already exist in the default. (This might should be configurable)
A current limitation with this method for discussion is that it would not be possible to remove from the default, only to add to it.
NB: this is the first step toward a larger re-configuration effort that is needed. Including:
- bin/omero configjs or similar.
- Self-registering plugins
Change History (6)
comment:1 Changed 10 years ago by jamoore
comment:2 Changed 10 years ago by jamoore
- Description modified (diff)
comment:3 Changed 10 years ago by jamoore
- Owner changed from web-team@… to aknab
comment:4 Changed 10 years ago by spli
- Cc spli added
comment:5 Changed 10 years ago by aknab
Different implementation based on https://github.com/openmicroscopy/openmicroscopy/pull/1905 at https://github.com/openmicroscopy/openmicroscopy/pull/2030.
- Allows adding to and removing from the default value
- Allows multiple independent operations on the same settings, e.g. when installing multiple OMERO.web plugins
comment:6 Changed 10 years ago by sbesson
- Resolution set to fixed
- Status changed from new to closed
PR https://github.com/openmicroscopy/openmicroscopy/pull/2041 opened against dev_5_0 for 5.0.0-rc2
For a slightly similar implementation, more complete but a bit more complex, see Andreas' https://github.com/knabar/openmicroscopy/commit/785fee6cb7b2cf6e667a953b966f4eb7b83291b8