Task #12393 (closed)
Bug: ROI Tool deselects after save, doesn't update inspector for 'rectangle' ROIs
| Reported by: | khgillen | Owned by: | jburel |
|---|---|---|---|
| Priority: | trivial | Milestone: | OMERO-5.2.0 |
| Component: | Insight | Version: | 5.1.0-m0 |
| Keywords: | ROI | Cc: | ux@… |
| Resources: | n.a. | Referenced By: | n.a. |
| References: | n.a. | Remaining Time: | n.a. |
| Sprint: | n.a. |
Description (last modified by khgillen)
Using Trout Merge 5.1 Insight.
First load of the ROI tool has a clear 'Inspector' tab with no UI value elements. This makes sense as no ROI is selected.
Changing inspected values of a Rectangle ROI, e.g. colour, and pressing 'save' deselects the ROI in the 'Manager' but the inspector tab is not blanked out - the values are all still set from the last ROI loaded. Choosing 'Manager' and then 'Inspector' without clicking and the values are all still loaded for the last ROI.
Making updates to the inspector values are not saved anywhere, though it appears that you're still editing the last ROI. Pressing save has no apparent effect, since these changes are not persisted to any ROI.
Note - making a change to a Text ROI and pressing save blanks out the 'Inspector' tab which is the behaviour I'd have expected. Perhaps this is a bug specific to non-text or just the Rectangle ROI type.
Noticed this with Trout/Merge? http://trout.openmicroscopy.org/merge/webclient/img_detail/30601/ drawing a rectangle ROI and changing the colour.
Change History (5)
comment:1 Changed 10 years ago by khgillen
- Description modified (diff)
- Version changed from 5.0.2 to 5.1.0-m0
comment:2 Changed 10 years ago by jburel
comment:3 Changed 10 years ago by khgillen
Further testing shows that if you draw four rectangle ROIs, this behaviour only happens on every second ROI. E.g. behaviour happens on the first and third, or second and fourth - not sure which, or even if that's consistent.
To replicate, add four rectangle ROI to an image on Trout, then select one, change the colour, hit save ROI - and if it clears the selected ROI, pick the rectangular ROI next to it and repeat.
comment:4 Changed 9 years ago by jburel
- Milestone changed from 5.1.4 to 5.2.0
- Resolution set to fixed
- Status changed from new to closed
Modified the behaviour as part of the work on roi-annotations see https://github.com/openmicroscopy/openmicroscopy/pull/4044
comment:5 Changed 9 years ago by jamoore
- Milestone changed from 5.2.0 to OMERO-5.2.0
Splitting due to milestone decoupling.
I followed the steps and did not manage to reproduce the issue. Kenny, you will have to show me.