Task #12693 (closed)
Opened 9 years ago
Closed 9 years ago
Bug: NDfilter density vv transmittance
| Reported by: | wmoore | Owned by: | ajpatterson |
|---|---|---|---|
| Priority: | critical | Milestone: | 5.1.0 |
| Component: | Model | Version: | n.a. |
| Keywords: | n.a. | Cc: | mlinkert, rleigh, jburel |
| Resources: | n.a. | Referenced By: | n.a. |
| References: | n.a. | Remaining Time: | n.a. |
| Sprint: | n.a. |
Description
In Deltavision files, ND Filter is stored as NDFilter: 10% which means 10% transmittance. BioFormats correctly saves this as 0.1 and it is displayed as 10% in Insight.
However, our schema http://www.openmicroscopy.org/Schemas/Documentation/Generated/OME-2013-06/ome.html states that NDFilter should be as "Optical Density", not transmittance.
The NDfilter attribute is used to specify the combined effect of any neutral density filters used. [units optical density expressed as a PercentFraction]
So, either we need to change how we're storing (and displaying) Deltavision NDfilters, OR we change the model to be "transmittance" instead of "optical density". Changing the wording of the model is probably easier, and would bring NDFilter into alignment with other filters in the model which use "transmittance" instead of density.
Change History (4)
comment:1 Changed 9 years ago by ajpatterson
comment:2 Changed 9 years ago by ajpatterson
- Status changed from new to accepted
comment:3 Changed 9 years ago by ajpatterson
A value is set for NDFilter in DeltavisionReader.java and SlidebookReader.java.
comment:4 Changed 9 years ago by ajpatterson
- Resolution set to fixed
- Status changed from accepted to closed
Changed wording in commit to: https://github.com/openmicroscopy/bioformats/pull/1632