Task #13188 (new)
Opened 8 years ago
Last modified 8 years ago
Bug: Additional tiling defects — at Version 1
Reported by: | rleigh | Owned by: | mlinkert |
---|---|---|---|
Priority: | minor | Milestone: | Unscheduled |
Component: | Bio-Formats | Version: | Bio-Formats-5.1.8 |
Keywords: | n.a. | Cc: | |
Resources: | n.a. | Referenced By: | n.a. |
References: | n.a. | Remaining Time: | n.a. |
Sprint: | n.a. |
Description (last modified by rleigh)
This is a followup ticket for https://trac.openmicroscopy.org/ome/ticket/12596
While expanding the coverage of the C++ test cases, I've identified some additional variants which aren't properly handled.
Tile height greater than image height:
int8/data-layout-int8-32x32planar-pi1-tile-32x48-ordered-optimal.tiff
int8/data-layout-int8-32x32planar-pi1-tile-32x64-ordered-optimal.tiff
int8/data-layout-int8-32x32planar-pi2-tile-32x48-ordered-optimal.tiff
int8/data-layout-int8-32x32planar-pi2-tile-32x64-ordered-optimal.tiff
int8/data-layout-int8-32x37planar-pi1-tile-32x48-ordered-optimal.tiff
int8/data-layout-int8-32x37planar-pi1-tile-32x64-ordered-optimal.tiff
int8/data-layout-int8-64x32planar-pi1-tile-64x48-ordered-optimal.tiff
int8/data-layout-int8-64x32planar-pi1-tile-64x64-ordered-optimal.tiff
BitsPerSample?=1 BIT pixel type with padding for strip scanlines:
bit/data-layout-bit-43x32chunky-pi1-strip-14-ordered-optimal.tiff
bit/data-layout-bit-43x32chunky-pi1-strip-2-ordered-optimal.tiff
bit/data-layout-bit-43x32chunky-pi1-strip-32-ordered-optimal.tiff
bit/data-layout-bit-43x32chunky-pi1-strip-5-ordered-optimal.tiff
bit/data-layout-bit-43x32chunky-pi1-tile-16x16-ordered-optimal.tiff
bit/data-layout-bit-43x32chunky-pi1-tile-16x32-ordered-optimal.tiff
bit/data-layout-bit-43x32chunky-pi1-tile-32x64-ordered-optimal.tiff
bit/data-layout-bit-43x32chunky-pi2-tile-16x32-ordered-optimal.tiff
For the bit data, it looks like it's mainly restricted to chunky rather than planar data, though there are several hundred failing cases; I've just included a small selection here. The attached archive has a fairly comprehensive test set of many variants, which can be e.g. imported into OMERO in bulk to view.
For the bit data, I'm also not 100% sure if the samples here are correct. They might be, but I can't confirm it definitively without some other software capable of reading them, since the C++ unit tests only check if that the data round-trips and compares with a PNG reference image; it can't objectively test whether the packing is correct if it is writing and reading it using an incorrect assumption. All of the other software I tested with mishandles chunky bitmasks.
Change History (2)
Changed 8 years ago by rleigh
comment:1 Changed 8 years ago by rleigh
- Description modified (diff)
Test data files