Task #13272 (closed)
Opened 8 years ago
Closed 8 years ago
RFE: allow offline maven build (LocationTest)
| Reported by: | mtbcarroll | Owned by: | mtbcarroll |
|---|---|---|---|
| Priority: | minor | Milestone: | n.a. |
| Component: | Bio-Formats | Version: | n.a. |
| Keywords: | n.a. | Cc: | bf@… |
| Resources: | n.a. | Referenced By: | n.a. |
| References: | n.a. | Remaining Time: | n.a. |
| Sprint: | n.a. |
Description (last modified by mtbcarroll)
Without -DskipTests one can't build Bio-Formats when offline because LocationTest fails. It's a pain to find components/formats-common/test/loci/common/utests/testng-template.xml, remove LocationTest, and maintain that change. Far nicer would be if the failing tests could simply skip if the host is wholly offline. For instance, one could use listeners as in https://github.com/hierynomus/assumeng with some kind of methods = {"isOnline"} assumption, or even simply throw SkipException where necessary.
Change History (3)
comment:1 Changed 8 years ago by mtbcarroll
- Description modified (diff)
comment:2 Changed 8 years ago by mtbcarroll
- Owner changed from dgault to mtbcarroll
- Status changed from new to accepted
comment:3 Changed 8 years ago by mtbcarroll
- Resolution set to fixed
- Status changed from accepted to closed
Note: See
TracTickets for help on using
tickets.
You may also have a look at Agilo extensions to the ticket.
In the longer term these tests should probably use TestNG's parameterization but given the current structure this is fixed adequately by https://github.com/openmicroscopy/bioformats/pull/2506.