Bug: Search Exception

[saloynton]

I was testing the search and switching between looking at the search tab and the tags tab in the data manager and the following exception occurred. Is this the same problem as ticket #9162?

java.lang.Exception: java.lang.ClassCastException: pojos.DatasetData cannot be cast to org.openmicroscopy.shoola.env.data.model.TimeRefObject
	at org.openmicroscopy.shoola.env.data.views.calls.DMRefreshLoader$5.doCall(DMRefreshLoader.java:395)
	at org.openmicroscopy.shoola.env.data.views.BatchCall.doStep(BatchCall.java:144)
	at org.openmicroscopy.shoola.util.concur.tasks.CompositeTask.doStep(CompositeTask.java:226)
	at org.openmicroscopy.shoola.env.data.views.CompositeBatchCall.doStep(CompositeBatchCall.java:126)
	at org.openmicroscopy.shoola.util.concur.tasks.ExecCommand.exec(ExecCommand.java:165)
	at org.openmicroscopy.shoola.util.concur.tasks.ExecCommand.run(ExecCommand.java:276)
	at org.openmicroscopy.shoola.util.concur.tasks.AsyncProcessor$Runner.run(AsyncProcessor.java:91)
	at java.lang.Thread.run(Unknown Source)

	at org.openmicroscopy.shoola.env.ui.UserNotifierImpl.showErrorDialog(UserNotifierImpl.java:189)
	at org.openmicroscopy.shoola.env.ui.UserNotifierImpl.notifyError(UserNotifierImpl.java:287)
	at org.openmicroscopy.shoola.env.ui.UserNotifierImpl.notifyError(UserNotifierImpl.java:257)
	at org.openmicroscopy.shoola.agents.treeviewer.DataBrowserLoader.handleException(DataBrowserLoader.java:148)
	at org.openmicroscopy.shoola.env.data.events.DSCallAdapter.eventFired(DSCallAdapter.java:84)
	at org.openmicroscopy.shoola.env.data.views.BatchCallMonitor$1.run(BatchCallMonitor.java:124)
	at java.awt.event.InvocationEvent.dispatch(Unknown Source)
	at java.awt.EventQueue.dispatchEventImpl(Unknown Source)
	at java.awt.EventQueue.access$000(Unknown Source)
	at java.awt.EventQueue$1.run(Unknown Source)
	at java.awt.EventQueue$1.run(Unknown Source)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.AccessControlContext$1.doIntersectionPrivilege(Unknown Source)
	at java.awt.EventQueue.dispatchEvent(Unknown Source)
	at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
	at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
	at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
	at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
	at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
	at java.awt.EventDispatchThread.run(Unknown Source)

[saloynton]

This exception also occurred while tagging a project or dataset and switching to the tags tab in the data manager to view the tagged project or dataset.

[mtbcarroll]

In a tree rooted at TagAnnotationData, DMRefreshLoader.makeTagsBatchCall seems to expect nodes that aren't one of those to instead be TimeRefObjects. In RefreshExperimenterDataLoader.load(), if there were any DatasetDatas among RefreshExperimenterDef.expandedTopNodes it looks like they would get through.

[mtbcarroll]

Interestingly, DMRefreshLoader.retrieveData has special handling for finding DatasetDatas and TimeRefObjects together among the nodes: perhaps some of the other make* methods also need improved DatasetData handling, assuming such things are also okay among the nodes argument for them.

What is known about which version of Insight exhibited this bug, and how it can be reproduced? I've been tagging datasets and images and searching for them and whatnot and haven't yet managed to see it once.

[mtbcarroll]

Ha, reproduced it, in hitting "refresh" in the tags browser. Also, I have an empty dataset tagged, that the tags browser is showing as having 3 items in instead of 0.

[mtbcarroll]

To reproduce the exception: tag a dataset, find it in the tags browser, expand the dataset then hit refresh.

[mtbcarroll]

So, in the above comments I now have a clear view of how to reproduce the issue and what causes the bug. Unfortunately, I don't understand DMRefreshLoader well enough to see how it should be fixed.

[jburel]

see ​https://github.com/openmicroscopy/openmicroscopy/pull/1534