Task #10198 (new)
Opened 12 years ago
Last modified 8 years ago
Bug: lastModification timestamp is ignored by OMERO.tables update()
| Reported by: | spli | Owned by: | spli |
|---|---|---|---|
| Priority: | minor | Milestone: | Metadata |
| Component: | API | Version: | OMERO-5.2.0 |
| Keywords: | n.a. | Cc: | analysis@… |
| Resources: | n.a. | Referenced By: | n.a. |
| References: | n.a. | Remaining Time: | n.a. |
| Sprint: | n.a. |
Description
The Data::lastModification timestamp should prevent an update being made to a table if it has been modified in another thread. It doesn't (has it ever?).
Change History (4)
comment:1 Changed 12 years ago by jmoore
comment:2 Changed 12 years ago by spli
- Owner set to spli
comment:3 Changed 9 years ago by jburel
- Milestone changed from Unscheduled to Metadata
- Version set to OMERO-5.2.0
comment:4 Changed 8 years ago by spli
I think I've inadvertently discovered a possible cause
The @stamped decorator requires an optional update parameter to update the timestamp: https://github.com/openmicroscopy/openmicroscopy/blob/v5.3.0-m2/components/tools/OmeroPy/src/omero/tables.py#L55
This parameter isn't included in any uses of @stamped which involve modifying the table, e.g. https://github.com/openmicroscopy/openmicroscopy/blob/v5.3.0-m2/components/tools/OmeroPy/src/omero/tables.py#L494
What's not clear is why some modifying methods don't use @stamped at all, e.g.
add_meta_map:: https://github.com/openmicroscopy/openmicroscopy/blob/v5.3.0-m2/components/tools/OmeroPy/src/omero/tables.py#L432
append:: https://github.com/openmicroscopy/openmicroscopy/blob/v5.3.0-m2/components/tools/OmeroPy/src/omero/tables.py#L468
The fact that "git grep last ." under OmeroPy/test/tablestest returns nothing doesn't bode well.