Notice: In order to edit this ticket you need to be either: a Product Owner, The owner or the reporter of the ticket, or, in case of a Task not yet assigned, a team_member"

Task #10198 (new)

Opened 7 years ago

Last modified 3 years ago

Bug: lastModification timestamp is ignored by OMERO.tables update()

Reported by: spli Owned by: spli
Priority: minor Milestone: Metadata
Component: API Version: OMERO-5.2.0
Keywords: n.a. Cc: analysis@…
Resources: n.a. Referenced By: n.a.
References: n.a. Remaining Time: n.a.
Sprint: n.a.

Description

The Data::lastModification timestamp should prevent an update being made to a table if it has been modified in another thread. It doesn't (has it ever?).

Change History (4)

comment:1 Changed 7 years ago by jmoore

The fact that "git grep last ." under OmeroPy/test/tablestest returns nothing doesn't bode well.

comment:2 Changed 7 years ago by spli

  • Owner set to spli

comment:3 Changed 4 years ago by jburel

  • Milestone changed from Unscheduled to Metadata
  • Version set to OMERO-5.2.0

comment:4 Changed 3 years ago by spli

I think I've inadvertently discovered a possible cause

The @stamped decorator requires an optional update parameter to update the timestamp: https://github.com/openmicroscopy/openmicroscopy/blob/v5.3.0-m2/components/tools/OmeroPy/src/omero/tables.py#L55

This parameter isn't included in any uses of @stamped which involve modifying the table, e.g. https://github.com/openmicroscopy/openmicroscopy/blob/v5.3.0-m2/components/tools/OmeroPy/src/omero/tables.py#L494

What's not clear is why some modifying methods don't use @stamped at all, e.g.

add_meta_map:: https://github.com/openmicroscopy/openmicroscopy/blob/v5.3.0-m2/components/tools/OmeroPy/src/omero/tables.py#L432
append:: https://github.com/openmicroscopy/openmicroscopy/blob/v5.3.0-m2/components/tools/OmeroPy/src/omero/tables.py#L468

Note: See TracTickets for help on using tickets. You may also have a look at Agilo extensions to the ticket.

1.3.13-PRO © 2008-2011 Agilo Software all rights reserved (this page was served in: 0.146128 sec.)

We're Hiring!