Bug: win32 errors on bin\omero (admin, web, ...)

[jamoore]

Error when not in a console as an admin:

C:\>python %HOMEPATH%\OMERO-qa-upgrade.py
...
Traceback (most recent call last):
 File "C:\OMERO-CURRENT\lib\python\omero_web_iis.py", line 73, in <module>
   permit_iis(CONFIG)
 File "C:\OMERO-CURRENT\lib\python\omero_web_iis.py", line 69, in permit_iis
   SetNamedSecurityInfo(filename, SE_FILE_OBJECT, DACL_SECURITY_INFORMATION, None, None, fileDacl, None )
pywintypes.error: (5, 'SetNamedSecurityInfo', 'Access is denied.')
Traceback (most recent call last):
 File "\Users\ome\OMERO-qa-upgrade.py", line 392, in <module>
   u = WindowsUpgrade(dir)
 File "\Users\ome\OMERO-qa-upgrade.py", line 224, in __init__
   self.stop(_)
 File "\Users\ome\OMERO-qa-upgrade.py", line 240, in stop
   self.stopweb(_)
 File "\Users\ome\OMERO-qa-upgrade.py", line 339, in stopweb
   _("web iis --remove")
 File "\Users\ome\OMERO-qa-upgrade.py", line 296, in _
   self.cli.invoke(command, strict=True)
 File "c:\OMERO-CURRENT\lib\python\omero\cli.py", line 748, in invoke
   self.assertRC()
 File "c:\OMERO-CURRENT\lib\python\omero\cli.py", line 737, in assertRC
   raise NonZeroReturnCode(self.rv, "assert failed")
omero.cli.NonZeroReturnCode: assert failed

Cause unknown:

c:\>OMERO-CURRENT\bin\omero admin restart
Server not running
No descriptor given. Using etc\grid\windefault.xml
OMERO.master service startup failed: (1058) The service cannot be started, either because it is disabled or because it has no
Traceback (most recent call last):
  File "c:\OMERO-CURRENT\bin\\omero", line 125, in <module>
    rv = omero.cli.argv()
  File "c:\OMERO-CURRENT\lib\python\omero\cli.py", line 1195, in argv
    cli.invoke(args[1:])
  File "c:\OMERO-CURRENT\lib\python\omero\cli.py", line 745, in invoke
    stop = self.onecmd(line, previous_args)
  File "c:\OMERO-CURRENT\lib\python\omero\cli.py", line 814, in onecmd
    self.execute(line, previous_args)
  File "c:\OMERO-CURRENT\lib\python\omero\cli.py", line 894, in execute
    args.func(args)
  File "c:\OMERO-CURRENT\lib\python\omero\plugins\prefs.py", line 68, in open_and_close_config
    return func(*args, **kwargs)
  File "c:\OMERO-CURRENT\lib\python\omero\plugins\admin.py", line 512, in restart
    self.start(args, config)
  File "c:\OMERO-CURRENT\lib\python\omero\plugins\prefs.py", line 68, in open_and_close_config
    return func(*args, **kwargs)
  File "c:\OMERO-CURRENT\lib\python\omero\plugins\admin.py", line 444, in start
    self.startasync(args, config)
  File "c:\OMERO-CURRENT\lib\python\omero\plugins\prefs.py", line 68, in open_and_close_config
    return func(*args, **kwargs)
  File "c:\OMERO-CURRENT\lib\python\omero\plugins\admin.py", line 432, in startasync
    win32service.DeleteService(hs)
pywintypes.error: (1072, 'DeleteService', 'The specified service has been marked for deletion.')

We will need to handle these and likely all exceptions that come from the use of win32 directly.

[bpindelski]

After discussing with Josh, two possible solutions came to mind:
1) Review omero/plugins/admin.py and make sure to catch all pywintypes.error elements. Also look at omero_web_iis.py and see where to catch the exception.
2) Create a decorator for CLI actions needing Administrator privileges that checks if the Command Prompt has been started with elevated privileges.

[jmoore]

Another issue on bin\omero web iis:

C:\>OMERO-CURRENT\bin\omero web iis

0 static files copied to 'C:/OMERO-CURRENT/lib/python/omeroweb/static' (804 unmodified).
Traceback (most recent call last):
  File "C:\OMERO-CURRENT\lib\python\omero_web_iis.py", line 73, in <module>
    permit_iis(CONFIG)
  File "C:\OMERO-CURRENT\lib\python\omero_web_iis.py", line 64, in permit_iis
    iusr, domain, type = LookupAccountName("", "IUSR")
pywintypes.error: (1332, 'LookupAccountName', 'No mapping between account names and security IDs was done.')

[bpindelski]

The new error reported by Josh might be related to the line:
iusr, domain, type = LookupAccountName("", "IUSR")
in components/tools/OmeroPy/src/omero_web_iis.py
that expects the IIS user to be IUSR. The script has been run with IIS6 on Windows Server 2003.

[bpindelski]

Similar bug that would be worth fixing along the way: ​https://trac.openmicroscopy.org.uk/ome/ticket/6980

[jburel]

Moved from sprint 2013-03-12 (6))

[jburel]

Moved from sprint 2013-04-09 (7))

[jamoore]

See ​https://trello.com/c/K6JDIYpt