Bug: Tags on import with ns:""

[khgillen]

Using FS testing release Gretzky, also seen on 4.4.6 release.

Batch adding tags during/post import with the importer "add tags to images" option will tag images, but when viewing the 'tags' view in Web, the tags created by the importer don't show up.

They do appear in the annotations window in web, but when viewing by tag (​https://gretzky.openmicroscopy.org.uk/omero/webclient/usertags/) they don't show up.

Adding tags from Insight, the tags show up in Web, just not when created with the importer.

Also - not sure if this is the same, or a different bug, but the thumbnails in Insight don't have the annotation symbol when they have tags assigned only by the importer - once you assign the tag within insight, and they become visible to Web, they also acquire their thumbnail with the annotation symbol.

[wmoore]

Tags created in the Insight importer have an empty string as namespace (if created elsewhere, ns is Null). The empty string ns prevents them appearing in the web as we get orphaned tags with:

sql = "select tg from TagAnnotation tg where ((ns=:ns) or (ns is null and not exists ( select aal from AnnotationAnnotationLink as aal where aal.child=tg.id))) "

[wmoore]

This has also been reported in #10248 and #10405

[wmoore]

Fixed in ​https://github.com/openmicroscopy/openmicroscopy/pull/749

[wmoore]

Reassigning to JM to fix the issue of Insight writing empty strings as the namespace for tags created at import.

Re: Kenny's comment:

Also - not sure if this is the same, or a different bug, but the thumbnails in Insight don't have the annotation symbol when they have tags assigned only by the importer - once you assign the tag within insight, and they become visible to Web, they also acquire their thumbnail with the annotation symbol.

[jburel]

The icon is due to the count of annotation not working correctly server side. We have a ticket for that.

[jburel]

All the annotations created using Annotations Pojos objects have been created using an empty string in the namespace i.e.

    protected AnnotationData(Class<? extends Annotation> annotationClass) {
        if (annotationClass == null) {
            throw new IllegalArgumentException("annotationClass cannot be null");
        }
        try {
            Annotation a = annotationClass.newInstance();
            a.setNs(rstring(""));
            setValue(a);
        } catch (Exception e) {
            throw new IllegalArgumentException("Unkown annotation type: "
                    + annotationClass.getName());
        }
    }

This will probably require an upgrade (for develop) to replace the empty string by null.

[jburel]

Fix see ​https://github.com/openmicroscopy/openmicroscopy/pull/804

[jburel <j.burel@…>]

(In [08c2d8b1378d21143d13830336a877f6b61d884a/ome.git] on branch develop) Do not set the namespace to an empty string (see #10393)

[Will Moore <will@…>]

(In [bd5be6dfd6cdc5d861237ff4dd9836e9b8ce94ef/ome.git] on branch develop) Web listTags() includes Tags with empty string Namespace. See #10393