Task #10516 (closed)
Opened 6 years ago
Closed 6 years ago
Blitz i.linkAnnotation (sameOwner=False)
| Reported by: | wmoore | Owned by: | wmoore |
|---|---|---|---|
| Priority: | major | Milestone: | OMERO-5 |
| Component: | OmeroPy | Version: | 4.4.9 |
| Keywords: | n.a. | Cc: | cxallan, cneves-x, jamoore |
| Resources: | n.a. | Referenced By: | n.a. |
| References: | n.a. | Remaining Time: | n.a. |
| Sprint: | n.a. |
Description
By default, if I'm an Admin and I'm linking an annotation to data belonging to another user:
image.linkAnnotation( comment )
then sameOwner = True by default, so the comment is owned by the owner of the data.
This is what's used when I do
omero.gateway.CommentAnnotationWrapper.createAndLink(image, ns=None, val=cTxt)
but here we don't have a change to pass sameOwner = True.
After discussion with Carlos, it's OK to change the default to sameOwner = False, since True only makes sense in JCB context. However, this should be considered an API change (major release).
Also, we should add sameOwner parameter to createAndLink() but this also should NOT change the default behaviour prior to major release.
Change History (1)
comment:1 Changed 6 years ago by wmoore
- Resolution set to fixed
- Status changed from new to closed
- Version set to 4.4.9
Note: See
TracTickets for help on using
tickets.
You may also have a look at Agilo extensions to the ticket.
https://github.com/openmicroscopy/openmicroscopy/pull/1730