Warning: Can't synchronize with repository "(default)" (/home/git/ome.git does not appear to be a Git repository.). Look in the Trac log for more information.
Notice: In order to edit this ticket you need to be either: a Product Owner, The owner or the reporter of the ticket, or, in case of a Task not yet assigned, a team_member"

Task #10522 (closed)

Opened 11 years ago

Closed 11 years ago

Bug: ZVI ROI parsing issue

Reported by: rleigh Owned by: rleigh
Priority: minor Milestone: Unscheduled
Component: Bio-Formats Version: n.a.
Keywords: n.a. Cc:
Resources: n.a. Referenced By: n.a.
References: n.a. Remaining Time: n.a.
Sprint: n.a.

Description

zeiss-zvi/pki/E-07.zvi:

Found 0 ROIs, but 121 ROIs expected

Looks like we're not processing the ROI layer block properly for this file.

Change History (4)

comment:2 Changed 11 years ago by rleigh

For E-07.zvi:

00000000  03 00 04 10 00 10 08 00  08 00 00 00 6b 00 65 00  |............k.e.|
00000010  79 00 00 00 03 00 01 00  02 00 03 00 00 00 00 00  |y...............|
00000020

The ROI block is non-standard, so we erroneously think that there are 121 (0x79) ROIs when there are none. This is because there's a standard layer version "04 10 00 10", but we normally expect this to be followed immediately by a shape. Here the shape count after the "03 00 01 00 02 00 03 00" is actually 0. The additional bit is a string "key" ("08 00" with zero length, but null terminated). This can probably be special cased, but is otherwise harmless. Not clear what this is for, maybe it's the layer name. Why is the string length missing?

https://github.com/openmicroscopy/bioformats/pull/471 fixes the real parsing bugs found in the reader. The cosmetic issue above will be done next.

comment:3 Changed 11 years ago by rleigh

Fixed and merged.

comment:4 Changed 11 years ago by rleigh

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets. You may also have a look at Agilo extensions to the ticket.

1.3.13-PRO © 2008-2011 Agilo Software all rights reserved (this page was served in: 0.71878 sec.)

We're Hiring!