Notice: In order to edit this ticket you need to be either: a Product Owner, The owner or the reporter of the ticket, or, in case of a Task not yet assigned, a team_member"

Bug #1058 (closed)

Opened 12 years ago

Closed 12 years ago

Spring 2.5.5 upgrade breaks all clients

Reported by: jamoore Owned by: jamoore
Priority: blocker Cc: jburel, cxallan, atarkowska, bwzloranger
Sprint: n.a.
Total Remaining Time: n.a.

Description (last modified by jmoore)

Spring 2.5.5's LdapTemplate implementation doesn't accept non-String values

Spring changed their implementation of LdapTemplate to read only the String-valued instances out of the Properties-based environment. We use a ome.system.Principal instance as our user-name, so this breaks all RMI clients.

Spring 2.5.2+ does not handle the clients "properties" bean

Whereas in <= 2.5.1:

  new ServiceFactory(new Server("localhost", new Login("me","something"));

would work without a local.properties file, 2.5.2+ do not.

Change History (5)

comment:1 Changed 12 years ago by jmoore

  • Resolution set to fixed
  • Status changed from new to closed

r2731 closes.

comment:2 Changed 12 years ago by jmoore

  • Resolution fixed deleted
  • Status changed from closed to reopened

Another issue, which showed up only via WebAdmin? is in the Spring 2.5.5 jar. All the other components use the lifecycle.prepare target to copy local.properties et al. into target/generated/resources. WebAdmin? does not, which is why everything else seemed to work ok.

In fact, all Spring jars from 2.5.2 to 2.5.5 are broken for our usage. They do not properly lookup our properties ("omero.user", etc.) If I can't find a fix, we'll have to rollback.

comment:3 Changed 12 years ago by jmoore

  • Description modified (diff)
  • Summary changed from Spring 2.5.5's LdapTemplate implementation doesn't accept non-String values to Spring 2.5.5 upgrade breaks all clients

comment:4 Changed 12 years ago by jmoore

  • Owner changed from jburel to jmoore
  • Status changed from reopened to new

comment:5 Changed 12 years ago by jmoore

  • Resolution set to fixed
  • Status changed from new to closed

r2756 closes the parent context issue.

This is actually a fairly unattractive solution which could again break in a number of ways. I've logged #1068 to re-evaluate our use and clean it up. Breakage like this is pretty unnecessary.

Note: See TracTickets for help on using tickets. You may also have a look at Agilo extensions to the ticket.

1.3.13-PRO © 2008-2011 Agilo Software all rights reserved (this page was served in: 0.187094 sec.)

We're Hiring!