Task #10581 (closed)
Bug: store.getPlane() and store.getTile() return arrays with different endianness
| Reported by: | sbesson | Owned by: | jamoore |
|---|---|---|---|
| Priority: | critical | Milestone: | 5.0.0-rc1 |
| Component: | API | Version: | 4.4.8 |
| Keywords: | FS | Cc: | analysis@…, fs@…, java@… |
| Resources: | n.a. | Referenced By: | n.a. |
| References: | n.a. | Remaining Time: | 0.0d |
| Sprint: | OMERO 5 Beta 2 (1) |
Description
See https://github.com/openmicroscopy/openmicroscopy/pull/926 for a more complete description of the bug using OMERO.matlab.
This bug is only present on the develop branch.
Change History (12)
comment:1 Changed 11 years ago by mlinkert
- Cc fs@… added
- Keywords FS added
- Version set to 4.4.8
comment:2 Changed 11 years ago by jamoore
And as http://trac.openmicroscopy.org.uk/ome/ticket/11315 by Will including a failing test.
comment:3 Changed 10 years ago by wmoore
Also reported as failure of Kymograph script #11641 by Petr.
But, strangely, the Image_From_ROIs script is working (which uses getTiles() too).
comment:4 Changed 10 years ago by wmoore
- Priority changed from major to critical
Since this has been reported several times now, increasing priority
comment:5 Changed 10 years ago by jamoore
- Cc java@… added
- Milestone changed from OMERO-5 to 5.0.0-beta2
- Sprint set to OMERO 5 Beta 2 (1)
comment:6 Changed 10 years ago by jamoore
- Owner set to jamoore
- Status changed from new to accepted
comment:7 Changed 10 years ago by jamoore
Looks like an off by one in the tile. Running this:
directRow = rfs.getRow(0, 0, 0, 0) directTile = rfs.getTile(0, 0, 0, 0, 0, sizeX, 1)
returned arrays are:
2013-11-07 16:14:22,433 INFO [ org.perf4j.TimingLogger] (l.Server-7) start[1383837262429] time[4] tag[omero.call.success.ome.services.RawPixelsBean.getRow] 2013-11-07 16:14:22,433 INFO [ ome.services.util.ServiceHandler] (l.Server-7) Rslt: [1, -97, 1, -101, 1, -99, ... 4 more] 2013-11-07 16:14:22,436 INFO [ org.perf4j.TimingLogger] (l.Server-9) start[1383837262434] time[1] tag[omero.call.success.ome.services.RawPixelsBean.getTile] 2013-11-07 16:14:22,436 INFO [ ome.services.util.ServiceHandler] (l.Server-9) Rslt: [-97, 1, -101, 1, -99, 1, ... 4 more]
comment:8 Changed 10 years ago by jamoore
- Resolution set to fixed
- Status changed from accepted to closed
comment:9 Changed 10 years ago by Colin Blackburn <colin@…>
- Remaining Time set to 0
(In [8ac02f0c48d9d1bf2288a2b548068baf3cf71939/ome.git] on branch develop) Add swapIfRequired to getTileDirect (Fix #10581)
The other get*Direct methods all contain a call to
reader.swapIfRequired(). The same logic in the non-
direct methods is handled by a call to setOrder on
the newly created PixelData object.
comment:10 Changed 10 years ago by Josh Moore <josh@…>
(In [c10c83601530be84fdf61091544040cf6733137a/ome.git] on branch develop) Merge pull request #1759 from ximenesuk/testGetTile_11315_develop
fix #10581: getTile byte-ordering issue
comment:11 Changed 10 years ago by Colin Blackburn <colin@…>
(In [11a8f322cc6f27fe514f8b3fec75b18313c2991a/ome.git] on branch dev_4_4) Add swapIfRequired to getTileDirect (Fix #10581)
The other get*Direct methods all contain a call to
reader.swapIfRequired(). The same logic in the non-
direct methods is handled by a call to setOrder on
the newly created PixelData object.
comment:12 Changed 10 years ago by Josh Moore <josh@…>
(In [52381d2e3ef29096a89c7270a5872d8e6bdf12d8/ome.git] on branch dev_4_4) Merge pull request #1831 from ximenesuk/testGetTile_11315_dev44
fix #10581: getTile byte-ordering issue (rebased onto dev_4_4)
Also reported as http://trac.openmicroscopy.org.uk/ome/ticket/10619