Warning: Can't synchronize with repository "(default)" (/home/git/ome.git does not appear to be a Git repository.). Look in the Trac log for more information.
Notice: In order to edit this ticket you need to be either: a Product Owner, The owner or the reporter of the ticket, or, in case of a Task not yet assigned, a team_member"

Task #10659 (closed)

Opened 8 years ago

Closed 8 years ago

Loosen prefix restrictions in FS

Reported by: jamoore Owned by: mtbcarroll
Priority: major Milestone: 5.0.0-beta1
Component: General Version: n.a.
Keywords: fs Cc: fs@…
Resources: n.a. Referenced By: n.a.
References: n.a. Remaining Time: n.a.
Sprint: n.a.

Description

See comment https://github.com/openmicroscopy/openmicroscopy/commit/24c54949b82b82d45031763159ff3c9b4f4baadc#commitcomment-2942579

Raised by Andreas, since creating a file with a period was disallowed:

ValidationException: exception ::omero::ValidationException
{
    serverStackTrace =
    serverExceptionClass =
    message = Path contains illegal components
}

Change History (4)

comment:1 Changed 8 years ago by mtbcarroll

  • Status changed from new to accepted

Will remove "." prefix restriction but in the usual case clients should use ClientFilePathTransformer.getFsFileFromClientFile to prevent such validation errors.

comment:2 Changed 8 years ago by jamoore

Mark: would getFsFileFromClientFile silently change that value or throw an exception?

comment:3 Changed 8 years ago by mtbcarroll

It would provide an adjusted string that should validate okay, probably it would prefix it with an underscore or something: the idea is that the client supplies a locally constructed File instance that may be awkwardly named and gets back an FsFile instance that validates okay (because it directly corresponds to something the server file system should support). (The toString() of that instance can be supplied for importing or whatever.)

I do agree with removing the "." prefix restriction, though.

comment:4 Changed 8 years ago by mtbcarroll

  • Resolution set to fixed
  • Status changed from accepted to closed
Note: See TracTickets for help on using tickets. You may also have a look at Agilo extensions to the ticket.

1.3.13-PRO © 2008-2011 Agilo Software all rights reserved (this page was served in: 0.63169 sec.)

We're Hiring!