Task #10664 (new)
Opened 11 years ago
Last modified 9 years ago
Bug: non-deterministic behavior in RTypes
| Reported by: | jamoore | Owned by: | rleigh |
|---|---|---|---|
| Priority: | critical | Milestone: | Unscheduled |
| Component: | OmeroCpp | Version: | 4.4.8 |
| Keywords: | n.a. | Cc: | cpp@… |
| Resources: | n.a. | Referenced By: | n.a. |
| References: | n.a. | Remaining Time: | n.a. |
| Sprint: | n.a. |
Description
With the code in https://github.com/openmicroscopy/openmicroscopy/pull/963, periodic failures (depending on the gtest filter) arise in RTypesTest:
hudson@howe:~/hudson/workspace/OMERO-merge-stable/src/components/tools/OmeroCpp$ LD_LIBRARY_PATH=. test/unit/unit --gtest_filter=RTypesTest.* Running main() from gtest_main.cc Note: Google Test filter = RTypesTest.* [==========] Running 10 tests from 1 test case. [----------] Global test environment set-up. [----------] 10 tests from RTypesTest [ RUN ] RTypesTest.RDouble [ OK ] RTypesTest.RDouble (0 ms) [ RUN ] RTypesTest.RFloat [ OK ] RTypesTest.RFloat (0 ms) [ RUN ] RTypesTest.RInt test/unit/rtypes.cpp:30: Failure Expected: (rv1) < (rv2), actual: 1 vs 1 [ FAILED ] RTypesTest.RInt (0 ms) [ RUN ] RTypesTest.RLong test/unit/rtypes.cpp:30: Failure Expected: (rv1) < (rv2), actual: 1 vs 1 [ FAILED ] RTypesTest.RLong (0 ms) [ RUN ] RTypesTest.RTime test/unit/rtypes.cpp:30: Failure Expected: (rv1) < (rv2), actual: 1 vs 1 [ FAILED ] RTypesTest.RTime (0 ms) [ RUN ] RTypesTest.RString test/unit/rtypes.cpp:30: Failure Expected: (rv1) < (rv2), actual: 1 vs 1 [ FAILED ] RTypesTest.RString (0 ms) [ RUN ] RTypesTest.RArray test/unit/rtypes.cpp:30: Failure Expected: (rv1) < (rv2), actual: 1 vs 1 [ FAILED ] RTypesTest.RArray (0 ms) [ RUN ] RTypesTest.RList test/unit/rtypes.cpp:30: Failure Expected: (rv1) < (rv2), actual: 1 vs 1 [ FAILED ] RTypesTest.RList (0 ms) [ RUN ] RTypesTest.RSet test/unit/rtypes.cpp:30: Failure Expected: (rv1) < (rv2), actual: 1 vs 1 [ FAILED ] RTypesTest.RSet (0 ms) [ RUN ] RTypesTest.RMap [ OK ] RTypesTest.RMap (1 ms) [----------] 10 tests from RTypesTest (1 ms total) [----------] Global test environment tear-down [==========] 10 tests from 1 test case ran. (1 ms total) [ PASSED ] 3 tests. [ FAILED ] 7 tests, listed below: [ FAILED ] RTypesTest.RInt [ FAILED ] RTypesTest.RLong [ FAILED ] RTypesTest.RTime [ FAILED ] RTypesTest.RString [ FAILED ] RTypesTest.RArray [ FAILED ] RTypesTest.RList [ FAILED ] RTypesTest.RSet 7 FAILED TESTS
Comments also in https://github.com/openmicroscopy/openmicroscopy/pull/984
Change History (5)
comment:1 Changed 11 years ago by rleigh
comment:2 Changed 11 years ago by jamoore
- Milestone changed from OMERO-4.4.7 to OMERO-4.4.8
- Priority changed from blocker to critical
Moving to 4.4.8. This only applies use of the new comparison function on RCollections.
comment:3 Changed 11 years ago by jamoore
- Owner set to rleigh
- Version set to 4.4.8
Roger: assigning to you to decide if anything needs to be done for 4.4.9 or if this can be pushed.
comment:4 Changed 11 years ago by jamoore
- Milestone changed from OMERO-4.4.9 to OMERO-4.4.x
Pushing.
comment:5 Changed 9 years ago by jamoore
- Milestone changed from 5.x to Unscheduled
Note: See
TracTickets for help on using
tickets.
You may also have a look at Agilo extensions to the ticket.
It looks like the failures are due to the comparison function not working correctly in certain cases. Since it's comparing the array type using a vector comparison, and that's then comparing plain RTypes rather than the specialised forms, it's likely that this is then failing whenever the pointer of the handle changes since it's not going to compare the values of the contained objects. This needs to be changed to do a proper comparison using the real object type (where possible).