Context Navigation

← Previous Ticket
Next Ticket →

Warning: Can't synchronize with repository "(default)" (/home/git/ome.git does not appear to be a Git repository.). Look in the Trac log for more information.

Notice: In order to edit this ticket you need to be either: a Product Owner, The owner or the reporter of the ticket, or, in case of a Task not yet assigned, a team_member"

Task #10666 (closed)

Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

Bug: comment.getValue() handle 'None'

Reported by:	wmoore	Owned by:	wmoore
Priority:	major	Milestone:	OMERO-4.4.x
Component:	General	Version:	n.a.
Keywords:	n.a.	Cc:	s.besson@…, python-team@…
Resources:	n.a.	Referenced By:	n.a.
References:	n.a.	Remaining Time:	0.0d
Sprint:	2013-05-07 (8)

Description

If we have a Tag, Comment, Xml annotation that has a value of None, then this will throw an exception (should just return None).

def getValue (self):
        """ 
        Gets the value of the Tag
        
        @return:    Value
        @type:      String
        """
        
        return self._obj.textValue.val

File "/home/hudson/hudson/workspace/OMERO-merge-stable/src/dist/lib/python/omero/gateway/__init__.py", line 4120, in getValue
return self._obj.textValue.val
AttributeError: 'NoneType' object has no attribute 'val'

http://qa.openmicroscopy.org.uk/qa/feedback/5012/

References

Change History (3)

comment:1 Changed 11 years ago by jburel

Sprint changed from 2013-04-09 (7)) to 2013-05-07 (8)

Moved from sprint 2013-04-09 (7))

comment:2 Changed 11 years ago by wmoore

Resolution set to fixed
Status changed from new to closed

Fixed in https://github.com/openmicroscopy/openmicroscopy/pull/1249

comment:3 Changed 11 years ago by Will Moore <will@…>

Remaining Time set to 0

(In [93564320ddf2009b67e43f87b2cc8ae5e21da42a/ome.git] on branch develop) Blitz ann.getValue() checks for None. Fixes #10666

Note: See TracTickets for help on using tickets. You may also have a look at Agilo extensions to the ticket.

Download in other formats: