Warning: Can't synchronize with repository "(default)" (/home/git/ome.git does not appear to be a Git repository.). Look in the Trac log for more information.
Notice: In order to edit this ticket you need to be either: a Product Owner, The owner or the reporter of the ticket, or, in case of a Task not yet assigned, a team_member"

Task #10824 (closed)

Opened 9 years ago

Closed 7 years ago

RFE: NetworkChecker modifications

Reported by: jamoore Owned by: sebastien.simard@…
Priority: critical Milestone: 5.x
Component: Insight Version: 5.0.8
Keywords: n.a. Cc: jburel, cxallan, mtbcarroll, bpindelski, sylittlewood
Resources: n.a. Referenced By: n.a.
References: n.a. Remaining Time: n.a.
Sprint: n.a.

Description (last modified by jamoore)

See:

Now that isNetworkUp() is called on every remote invocation reducing blockages will become paramount.

Suggested improvements from a discussion with Chris Allan:

  • Move from testing openmicroscopy.org.uk to testing the server/port that Ice is configured to use. This may require housing the NetworkChecker inside of the SecurityContext, though on shutdown it's unclear which one should be used.
  • Set timeouts on all sockets. If using URL, set via URLConnection#setReadTimeout

Further improvements which could also be considered (perhaps as a second ticket):

Change History (10)

comment:2 Changed 9 years ago by jburel

Unfortunately it has to be made on every method call at the moment
Any Java 6 feature cannot be considered on 4.4.x since the minimum required is 1.5

comment:3 Changed 9 years ago by jamoore

  • Description modified (diff)

comment:4 Changed 9 years ago by jburel

Move from testing openmicroscopy.org.uk to testing the server/port that Ice is configured to use. This may require housing the NetworkChecker inside of the SecurityContext, though on shutdown it's unclear which one should be used.

That was the initial idea, but I did not have a chance to refactor the code. Note that the check only happens on linux due to again a limitation of Java 1.5

  • First thing to do will be to re-activate the Java 1.6 or higher code on develop to see.

comment:5 Changed 9 years ago by jamoore

  • Description modified (diff)

comment:6 Changed 9 years ago by jamoore

  • Description modified (diff)

comment:7 Changed 8 years ago by Melissa Linkert <melissa@…>

(In [005f8f6284402083558aa636495dd87f563154d4/ome.git] on branch develop) Use the reflected network check on non-Linux platforms

If it has been determined that the reflected check (i.e. using Java 1.6+
code) can be used, then try that first on non-Linux systems. If it
returns false or cannot be run, then the original Java 1.5 is still
used.

This prevents the network from being detected as down on non-Linux
systems with Java 1.7.0-b27.

See #10824, #10838, and #11244.

comment:8 Changed 8 years ago by jburel

The change made by the previous commit does not work i.e. return value is true. This explains the error reported .

comment:10 Changed 7 years ago by jburel

  • Resolution set to fixed
  • Status changed from new to closed
  • Version set to 5.0.8

This ticket can be closed.
Please re-open if required.

Note: See TracTickets for help on using tickets. You may also have a look at Agilo extensions to the ticket.

1.3.13-PRO © 2008-2011 Agilo Software all rights reserved (this page was served in: 0.67218 sec.)

We're Hiring!