Warning: Can't synchronize with repository "(default)" (/home/git/ome.git does not appear to be a Git repository.). Look in the Trac log for more information.
Notice: In order to edit this ticket you need to be either: a Product Owner, The owner or the reporter of the ticket, or, in case of a Task not yet assigned, a team_member"

Task #10827 (closed)

Opened 9 years ago

Closed 9 years ago

Last modified 8 years ago

Bug: Thumbnails in Plate display when in a read-only group broken

Reported by: cxallan Owned by: wmoore
Priority: blocker Milestone: OMERO-4.4.8
Component: Web Version: n.a.
Keywords: n.a. Cc: jburel, pwalczysko
Resources: n.a. Referenced By: n.a.
References: n.a. Remaining Time: n.a.
Sprint: n.a.

Description

With the move to using cached thumbnails in milestone:OMERO-4.4.7 we rely on all OMERO.web thumbnail requests being 96 pixels on the longest side. These 96 pixel on the longest side thumbnails are what are requested during Import and the only thumbnails we can have confidence in being there.

As in a read-only group no new Thumbnail objects can be created and linked to the Image this really must be the default. Furthermore requests for Thumbnails via the "direct" mechanism should be possible via render_thumbnail.

As a quick fix one can do the following:

diff --git a/components/tools/OmeroWeb/omeroweb/webgateway/static/webgateway/js/ome.plateview.js \
    b/components/tools/OmeroWeb/omeroweb/webgateway/static/webgateway/js/ome.plateview.js
index 93d5a95..94780a9 100644
--- a/components/tools/OmeroWeb/omeroweb/webgateway/static/webgateway/js/ome.plateview.js
+++ b/components/tools/OmeroWeb/omeroweb/webgateway/static/webgateway/js/ome.plateview.js
@@ -100,7 +100,7 @@ jQuery.WeblitzPlateview = function (elm, options) {
 jQuery._WeblitzPlateview = function (container, options) {
   var opts = jQuery.extend({
       baseurl: '',
-      width: 64,
+      width: 96,
       height: 48,
       useParentPrefix: true,
     }, options);
diff --git a/components/tools/OmeroWeb/omeroweb/webgateway/views.py \
    b/components/tools/OmeroWeb/omeroweb/webgateway/views.py
index c5a4631..f804f92 100644
--- a/components/tools/OmeroWeb/omeroweb/webgateway/views.py
+++ b/components/tools/OmeroWeb/omeroweb/webgateway/views.py
@@ -1168,7 +1168,7 @@ def plateGrid_json (request, pid, field=0, conn=None, **kwargs):
         return HttpResponseServerError('""', mimetype='application/javascript')
     grid = []
     prefix = kwargs.get('thumbprefix', 'webgateway.views.render_thumbnail')
-    thumbsize = int(request.REQUEST.get('size', 64))
+    thumbsize = int(request.REQUEST.get('size', 96))
     logger.debug(thumbsize)
 
     def urlprefix(iid):

However this has numerous side effects, not the least of which is that all thumbnails in every Plate view are now 96 pixels on their longest side rather than 64 pixels.

Change History (3)

comment:2 Changed 9 years ago by wmoore

  • Resolution set to fixed
  • Status changed from new to closed

Workaround in web is in the PR above. Underlying thumbs issue is in ticket #10618

comment:3 Changed 8 years ago by Will Moore <will@…>

(In [88717e31e3b0022722ace3c7a82521721ee07207/ome.git] on branch develop) Fix cached thumbs bug in SPW. See #10827

Note: See TracTickets for help on using tickets. You may also have a look at Agilo extensions to the ticket.

1.3.13-PRO © 2008-2011 Agilo Software all rights reserved (this page was served in: 0.83054 sec.)

We're Hiring!