Notice: In order to edit this ticket you need to be either: a Product Owner, The owner or the reporter of the ticket, or, in case of a Task not yet assigned, a team_member"

Task #10854 (closed)

Opened 6 years ago

Closed 5 years ago

Bug: NPE on unknown image delete spec

Reported by: jamoore Owned by: mtbcarroll
Priority: major Milestone: 5.1.0-m3
Component: Services Version: 5.0.5
Keywords: n.a. Cc: cxallan, knabar, bpindelski, mtbcarroll
Resources: n.a. Referenced By: n.a.
References: n.a. Remaining Time: n.a.
Sprint: n.a.

Description

On passing in the rdef ID rather than the image ID for /Image/Pixels/RenderingDef?

2013-05-08 05:47:27,315 INFO  [            ome.services.delete.Deletion] (2-thread-3) Deleting /Image/Pixels/RenderingDef:437627
2013-05-08 05:47:27,317 INFO  [                 org.perf4j.TimingLogger] (2-thread-3) start[1368006447315] time[2] tag[omero.graph.query.Image.Pixels.RenderingDef.ChannelBinding]
2013-05-08 05:47:27,317 DEBUG [       ome.services.graphs.BaseGraphSpec] (2-thread-3) Found 0 id(s) for [/Image/Pixels/RenderingDef/ChannelBinding;HARD]
2013-05-08 05:47:27,319 INFO  [                 org.perf4j.TimingLogger] (2-thread-3) start[1368006447317] time[2] tag[omero.graph.query.Image.Pixels.RenderingDef.CodomainMapContext]
2013-05-08 05:47:27,319 DEBUG [       ome.services.graphs.BaseGraphSpec] (2-thread-3) Found 0 id(s) for [/Image/Pixels/RenderingDef/CodomainMapContext;HARD]
2013-05-08 05:47:27,320 INFO  [                 org.perf4j.TimingLogger] (2-thread-3) start[1368006447319] time[1] tag[omero.graph.query.Image.Pixels.RenderingDef]
2013-05-08 05:47:27,320 DEBUG [       ome.services.graphs.BaseGraphSpec] (2-thread-3) Found 0 id(s) for [/Image/Pixels/RenderingDef;HARD]
2013-05-08 05:47:27,322 INFO  [                 org.perf4j.TimingLogger] (2-thread-3) start[1368006447320] time[2] tag[omero.graph.query.Image.Pixels.RenderingDef.QuantumDef]
2013-05-08 05:47:27,322 DEBUG [       ome.services.graphs.BaseGraphSpec] (2-thread-3) Found 0 id(s) for [/Image/Pixels/RenderingDef/QuantumDef;HARD]
2013-05-08 05:47:27,322 DEBUG [                      ome.util.SqlAction] (2-thread-3) ome.util.actions.PostgresSqlAction@27d2c08.groupInfoFor([Image, 437627])
2013-05-08 05:47:27,323 ERROR [      omero.cmd.graphs.DeleteI.@7fc277cf] (2-thread-3) Failure during Request.step:
java.lang.NullPointerException
        at ome.services.graphs.GraphState$1.copy(GraphState.java:140)
        at ome.system.SimpleEventContext.<init>(SimpleEventContext.java:72)

An exception printing "Image BAD_ID" should be returned so the user knows what happened.

Change History (4)

comment:1 Changed 5 years ago by jamoore

  • Owner changed from jamoore to mtbcarroll
  • Version set to 5.0.5

comment:2 Changed 5 years ago by mtbcarroll

My branch seems to throw,

ome.services.graphs.GraphException(message=cannot read all the specified objects of class ome.model.core.Image)

comment:3 Changed 5 years ago by mtbcarroll

  • Milestone changed from 5.x to 5.1.0-m3
  • Status changed from new to accepted

comment:4 Changed 5 years ago by mtbcarroll

  • Resolution set to fixed
  • Status changed from accepted to closed

Fixed by ​https://github.com/openmicroscopy/openmicroscopy/pull/3228.

Note: See TracTickets for help on using tickets. You may also have a look at Agilo extensions to the ticket.

1.3.13-PRO © 2008-2011 Agilo Software all rights reserved (this page was served in: 0.75915 sec.)

© 2000-2014 University of Dundee & Open Microscopy Environment. Creative Commons Attribution 3.0 Unported License
OME source code is available under the GNU General public license or through commercial license from Glencoe Software

We're Hiring!