Bug: constraints field only present on error

[jamoore]

On a successful delete of 2 images, a DoAllRsp is returned which does not have a constraints field like GraphConstraintERR does.

See screenshot in ​https://github.com/openmicroscopy/openmicroscopy/pull/1138

[jamoore]

2013-05-13 19:33:38,886 WARNI [      omeroweb.webclient.webclient_utils] (proc.08456) _formatReport:46 Delete warning: GraphException: OriginalFile:709 improperly linked by 1 objectsGraphException: Original
File:709 improperly linked by 1 objects
2013-05-13 19:33:38,914 ERROR [                omeroweb.webclient.views] (proc.08456) activities:2217 Traceback (most recent call last):
  File "/opt/hudson/workspace/OMERO-merge-develop2/src/dist/lib/python/omeroweb/webclient/views.py", line 2180, in activities
    if 'Fileset' in rsp.constraints:
AttributeError: 'DoAllRsp' object has no attribute 'constraints'

[jamoore]

This is almost certainly a result of having changed our delete strategy mid-flight. While fixing this, would it be possible to all add a "Delete all" button to make the two actions match?

[wmoore]

I don't want to add a "Delete All" button since the potential for accidental data loss is too great. See JM's nitpick e-mail 8th May

"To avoid the deletion of data by accident, all the images composing the MIF will have to be selected in order to delete the MIF"

[wmoore]

Fixed ​https://github.com/openmicroscopy/openmicroscopy/pull/1190

[Will Moore <will@…>]

(In [ed52b03f00c7259641d04170f1a8f1f4c8c10180/ome.git] on branch develop) Check delete rsp.constraints only if ERR. See #10889