Bug: web failed on delete dataset with partial MIF

[jamoore]

Occurred during demo 4.1. Server returned GraphConstraintERR but client showed green tick. In OMEROweb.log:

5-14 15:14:49,290 ERROR [      omeroweb.webclient.webclient_utils] (proc.13976) _formatReport:41 Format report: {'warning': '', 'error': ''}
2013-05-14 15:14:49,292 WARNI [                           omero.gateway] (proc.13976) debug:3439 ValueError on <class 'omeroweb.webclient.webclient_gateway.OmeroWebSafeCallWrapper'> to <2b8d8d06-4f63-4bdf-9471-cdfa6ff769d5omero.api.IContainer> getImages(('Dataset', [u'36'], None, <ServiceOptsDict: {'omero.session.uuid': 'dc3ed196-9af7-4d69-9f30-5de86a5a8c17', 'omero.group': '-1', 'omero.client.uuid': '2b8d8d06-4f63-4bdf-9471-cdfa6ff769d5'}>), {})
Traceback (most recent call last):
  File "/home/omero/slave/workspace/OMERO-merge-develop/src/dist/lib/python/omero/gateway/__init__.py", line 3457, in __call__
    return self.f(*args, **kwargs)
  File "/home/omero/slave/workspace/OMERO-merge-develop/src/dist/lib/python/omero_api_IContainer_ice.py", line 106, in getImages
    return _M_omero.api.IContainer._op_getImages.invoke(self, ((rootType, rootIds, options), _ctx))
ValueError: invalid value for element 0 of sequence<long>
2013-05-14 15:14:49,297 ERROR [                omeroweb.webclient.views] (proc.13976) activities:2217 Traceback (most recent call last):
  File "/home/omero/slave/workspace/OMERO-merge-develop/src/dist/lib/python/omeroweb/webclient/views.py", line 2194, in activities
    attempted_imgIds = [i.id.val for i in cs.getImages(dtype, obj_ids, None, conn.SERVICE_OPTS)]
  File "/home/omero/slave/workspace/OMERO-merge-develop/src/dist/lib/python/omero/gateway/__init__.py", line 3460, in __call__
    return self.handle_exception(e, *args, **kwargs)
  File "/home/omero/slave/workspace/OMERO-merge-develop/src/dist/lib/python/omeroweb/webclient/webclient_gateway.py", line 1941, in handle_exception
    e, *args, **kwargs)
  File "/home/omero/slave/workspace/OMERO-merge-develop/src/dist/lib/python/omero/gateway/__init__.py", line 3457, in __call__
    return self.f(*args, **kwargs)
  File "/home/omero/slave/workspace/OMERO-merge-develop/src/dist/lib/python/omero_api_IContainer_ice.py", line 106, in getImages
    return _M_omero.api.IContainer._op_getImages.invoke(self, ((rootType, rootIds, options), _ctx))
ValueError: invalid value for element 0 of sequence<long>

2013-05-14 15:14:49,297 ERROR [                omeroweb.webclient.views] (proc.13976) activities:2218 Status job 'dc3ed196-9af7-4d69-9f30-5de86a5a8c17/IHandlef669c44a-2e24-4e97-86e1-0f083c0fca24 -t:tcp -h 134.36.65.227 -p 52892'error:

[pwalczysko]

Supplementary information: Deletion of a dataset was attempted. The dataset consisted of a MIF, which was not complete (2 out of 3 images only were present in the Dataset). Although the UI showed the success, the Delete action did not go through. After refreshing of the UI, the dataset was still there, it was not deleted and not removed from display. (It was not removed from display after Refresh button was used - prior to Refresh the dataset was missing).

[wmoore]

Delete Dataset with partial MIF

[wmoore]

This seems to be working for me now. See screenshot: ​https://trac.openmicroscopy.org.uk/ome/attachment/ticket/10900/Screen%20shot%202013-05-20%20at%2016.38.38.png

Maybe a PR was missing from the demo build?

[jamoore]

This wasn't from a special demo build but rather from the daily build, so it's unlikely a PR was missing. Re-opening and assigning to Petr in case he's reproduced. Note: the issue in the stack trace isn't just the delete but an odd Ice sequence exception. Will, you'll likely need to synthetically cause an exception at that point to see if the green ticket hangs around.

[pwalczysko]

The discrepancy with @wmoore might be that I am testing on today's GRETZKY (Will probably tests locally).

The bug is still there, exactly as reported.
Once more today's workflow:

• import as user-4, file /Volumes/ome/data_repo/test_images_good/leica-lif/free edge 6.lif
• a datset will be created with 16 images of the MIF in it
• move the last image of the 16 into another dataset
• select the dataset with (now) 15 images of the MIF in it
• try to Delete it
• the Activities will show a following message (see screenshot)
• after refresh (in OMERO.web) the dataset is still there, undeleted

[wmoore]

Very strange: seem that if I try the following against a local server (using latest snoopy merge build) it works OK, but if I try connecting to gretzky and do the same it fails with the error above.

containerService.getImages("Dataset", ["53"], None)

Any ideas why Josh?

[wmoore]

Fixed the bug itself in ​https://github.com/openmicroscopy/openmicroscopy/pull/1190 and the incorrect display of green tick is fixed in ​https://github.com/openmicroscopy/openmicroscopy/pull/1193

[jamoore]

Almost certainly due to differences in the model and/or API, i.e. the Ice protocol is just broken between the client & server.

[Will Moore <will@…>]

(In [be1f1d1d9cbc92cc4fa06eaddaea990fe76b0a84/ome.git] on branch develop) Don't show green tick if delete Error. See #10900

[Josh Moore <josh@…>]

(In [adea48acfc0f7d7e7c8908f3a59662974dfaa335/ome.git] on branch develop) Merge pull request #1193 from will-moore/activities_web_bugs_May21st

Don't show green tick if delete Error. See #10900

[Will Moore <will@…>]

(In [9820373d25996d70baa348bc343a3e276051bb10/ome.git] on branch develop) Fix 'invalid value' error on failed MIF delete. See #10900