Task #11015 (closed)
Opened 11 years ago
Closed 8 years ago
Test Fake image Omero side
| Reported by: | jburel | Owned by: | cblackburn |
|---|---|---|---|
| Priority: | major | Milestone: | Metadata |
| Component: | General | Version: | OMERO-5.2.0 |
| Keywords: | n.a. | Cc: | fs@… |
| Resources: | n.a. | Referenced By: | n.a. |
| References: | n.a. | Remaining Time: | n.a. |
| Sprint: | n.a. |
Description
Currently several python tests use the "Fake image" approach to generate file.
No test in OMERO to make sure that is working correctly which could lead to some issues (none noticed so far)
Change History (11)
comment:1 Changed 11 years ago by cblackburn
- Owner set to cblackburn
- Status changed from new to accepted
comment:2 Changed 11 years ago by jamoore
I'm not sure an extensive OMERO suite of tests is needed for fakes. To OMERO, FakeReader is just another reader and therefore obeys whatever API/rules Bio-Formats puts in place. I've started adding unit tests in https://github.com/openmicroscopy/bioformats/pull/536 which it would definitely be good to expand.
comment:3 Changed 11 years ago by jburel
I was thinking of tests where the fake is used to generate MIF e.g. fake series=2. In that case we need to make sure that 2 images are created and linked to a single file set. (strategy used in some tests dealing with MIF)
or we manually create the file set and link the images to it in those tests.
Having those tests will be very useful in general for the "mix" DB later on.
comment:4 Changed 11 years ago by cblackburn
The test for image/pixels count is already done when the MIF is created. So bearing in mind Josh's comments, which I hadn't appreciated before this, how much more do we need on the OMERO side?
comment:5 Changed 11 years ago by jburel
could you point me to the tests you are mentioning Colin?
comment:6 Changed 8 years ago by jamoore
- Milestone changed from 5.x to Metadata
- Sprint FS demo 4.x deleted
comment:7 Changed 8 years ago by jamoore
Referencing ticket #11012 has changed sprint.
comment:8 Changed 8 years ago by jamoore
Referencing ticket #11012 has changed sprint.
comment:9 Changed 8 years ago by sbesson
- Version set to OMERO-5.2.0
Assuming the tests mentioned above is https://github.com/openmicroscopy/openmicroscopy/blob/develop/components/tests/python/library/__init__.py#L321. As the unit tests for FakeReader? are expanding, is there anything OMERO-specific left here?
comment:10 Changed 8 years ago by cblackburn
I'm not sure if anything more needs to be done. Fake images are used in several tests both using the method in the link above and directly in CLI import tests, this suggests at least an internal consistency. Combined with testing on the B-F side I can't see anything else that can be added on the OMERO side.
comment:11 Changed 8 years ago by sbesson
- Resolution set to fixed
- Status changed from accepted to closed
Closing this ticket. If we can think of concrete scenarios/workflows to be tested on the OMERO side (cf https://trac.openmicroscopy.org/ome/ticket/11015#comment:3), this might be an occasion to train more people on integration test.
There is a minimal amount of testing via set-up for other tests when importing a fake - assertions on pixels count - but a wider suite of tests would certainly be useful.