Task #11017 (closed)
Bug: MIF chgrp "Instrument" failed
| Reported by: | wmoore | Owned by: | jamoore |
|---|---|---|---|
| Priority: | blocker | Milestone: | 5.0.0-beta1 |
| Component: | Security | Version: | n.a. |
| Keywords: | fs | Cc: | ajpatterson, mtbcarroll, pwalczysko, jrswedlow, jburel, fs@… |
| Resources: | n.a. | Referenced By: | n.a. |
| References: | n.a. | Remaining Time: | 0.0d |
| Sprint: | FS demo 4.4 |
Description (last modified by jamoore)
Having moved a 2-image MIF: /zeiss-lsm-martin/051215-j-tf.mdb [01-01] to a new group (OK) tried to move to a new dataset in that group (drag & drop in web) - See error below.
Reported https://github.com/openmicroscopy/openmicroscopy/pull/1221#issuecomment-18684904
gretzky today, user-3, imported Images:3839,3840 into group:8, moved to group:7 (into Dataset:353). Then tried to move into Dataset:401
When I've seen a "Security Violation" like this before, it's been because the object (Instrument in this case) failed to have it's details.group.id updated to the new group.
SecurityViolation: exception ::omero::SecurityViolation
{
serverStackTrace = ome.conditions.SecurityViolation: Cannot read ome.model.acquisition.Instrument:Id_1329
at ome.security.basic.BasicACLVoter.throwLoadViolation(BasicACLVoter.java:163)
at ome.security.CompositeACLVoter.throwLoadViolation(CompositeACLVoter.java:92)
at ome.security.ACLEventListener.onPostLoad(ACLEventListener.java:104)
at org.hibernate.engine.TwoPhaseLoad.initializeEntity(TwoPhaseLoad.java:250)
at org.hibernate.loader.Loader.initializeEntitiesAndCollections(Loader.java:898)
at org.hibernate.loader.Loader.doQuery(Loader.java:773)
NB: should verify with the data from #10839
Change History (13)
comment:1 Changed 11 years ago by jamoore
comment:2 Changed 11 years ago by jamoore
After a clean build, I've now reproduced locally.
comment:3 Changed 11 years ago by jamoore
- Keywords fs added
- Remaining Time set to 1.5
- Status changed from new to accepted
comment:4 Changed 11 years ago by mtbcarroll
- Cc mtbcarroll added
comment:5 Changed 11 years ago by jamoore
- Description modified (diff)
comment:6 Changed 11 years ago by pwalczysko
- Cc pwalczysko added
comment:7 Changed 11 years ago by jburel
- Sprint changed from FS Demo 4.3 to FS demo 4.4
Moved from sprint FS Demo 4.3
comment:8 Changed 11 years ago by jamoore
Re-testing with today's gretzky.
comment:9 Changed 11 years ago by jamoore
This will minimally require a rebuild with https://github.com/openmicroscopy/openmicroscopy/pull/1288
comment:10 Changed 11 years ago by jamoore
- Cc jrswedlow jburel fs@… added
This issue is not corrected by PR 1228. I'll look into a solution but I don't know if it will be available today. If not, I would propose that this not be considered a blocker for Paris and that we simply avoid showing users chgrp on files with lots of Instrument metadata.
comment:11 Changed 11 years ago by jamoore
- Remaining Time changed from 1.5 to 0
- Resolution set to fixed
- Status changed from accepted to closed
comment:12 Changed 11 years ago by jmoore <josh@…>
(In [9f132ff809670edef76699a1ad7cbcdf5c33f89b/ome.git] on branch develop) Handle trans. range before filter (Fix #11017)
comment:13 Changed 11 years ago by Josh Moore <josh@…>
(In [449e0408c7c47dd34c7865f79c93e04b3f9abb5a/ome.git] on branch develop) Merge pull request #1299 from joshmoore/11017-instrument
Handle trans. range before filter (Fix #11017)
I've reproduced on gretzky with both the exact files that Will and Andrew were working with as well as a newly imported copy of the MDB files, but I can't reproduce locally. Might have to try writing an integration test for this.