Warning: Can't synchronize with repository "(default)" (/home/git/ome.git does not appear to be a Git repository.). Look in the Trac log for more information.
Notice: In order to edit this ticket you need to be either: a Product Owner, The owner or the reporter of the ticket, or, in case of a Task not yet assigned, a team_member"

Task #11074 (closed)

Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

Bug: Exported OME-TIFFs aren't deleted

Reported by: spli Owned by: jamoore
Priority: blocker Milestone: OMERO-4.4.9
Component: Export Version: n.a.
Keywords: n.a. Cc: omero-team@…
Resources: n.a. Referenced By: n.a.
References: n.a. Remaining Time: 0.0d
Sprint: Blocker 4.4.9 (1)

Description

In the BlitzGateway?:

im = conn.getObject('Image',56273)
z = im.exportOmeTiff()

The server writes the OME-TIFF to a temporary directory, but doesn't appear to delete it even after the sesion is closed. lsof shows no open handles to the temporary tiffs.

Change History (8)

comment:1 Changed 11 years ago by spli

  • Cc omero-team@… added; team@… removed
  • Priority changed from major to blocker

comment:2 Changed 11 years ago by spli

  • Component changed from General to Export
  • Milestone changed from Unscheduled to OMERO-4.4.9

comment:3 Changed 11 years ago by jamoore

  • Resolution set to fixed
  • Status changed from new to closed

PRs filed for develop https://github.com/openmicroscopy/openmicroscopy/pull/1260, but needs #10844 for testing. Leaving ticket open until this is backported to dev_4_4 (more important).

comment:4 Changed 11 years ago by jamoore

  • Resolution fixed deleted
  • Sprint set to Blocker 4.4.9 (1)
  • Status changed from closed to reopened

comment:5 Changed 11 years ago by jamoore

  • Owner set to jamoore
  • Status changed from reopened to accepted

comment:6 Changed 11 years ago by jamoore

  • Resolution set to fixed
  • Status changed from accepted to closed

dev_4_4 PR filed: https://github.com/openmicroscopy/openmicroscopy/pull/1261 with only minor conflicts (especially try/finally to ensure postClose)

comment:7 Changed 11 years ago by jmoore <josh@…>

  • Remaining Time set to 0

(In [73ca8be1e681badd79ef05b9060de2ec2d233a2b/ome.git] on branch develop) Refactor *Close into AbstractCloseableAmdServant? (Fix #11074)

Changing the signature of preClose and postClose in
AbstractAmdServant? to include an Ice.Current argument
(See 94fca87e891185b6ca4256512ef16812396d29df) left
ExporterI with an uncalled preClose method which in turn
left temp files dangling.

Adding @Override to the protected method would prevent
such errors in the future, but this refactoring goes a
step further and makes the methods abstract so that they
must be implemented.

comment:8 Changed 11 years ago by jmoore <josh@…>

(In [9f5c3ed5871c74636a153524399c8a87fab8f580/ome.git] on branch develop) Add OMERO_TEMPDIR to diagnostics output (See #11074)

Note: See TracTickets for help on using tickets. You may also have a look at Agilo extensions to the ticket.

1.3.13-PRO © 2008-2011 Agilo Software all rights reserved (this page was served in: 0.67238 sec.)

We're Hiring!