Warning: Can't synchronize with repository "(default)" (/home/git/ome.git does not appear to be a Git repository.). Look in the Trac log for more information.
Notice: In order to edit this ticket you need to be either: a Product Owner, The owner or the reporter of the ticket, or, in case of a Task not yet assigned, a team_member"

Task #11202 (closed)

Opened 11 years ago

Closed 10 years ago

Last modified 10 years ago

Adjust client-server negotiation of checksum algorithm

Reported by: mtbcarroll Owned by: mtbcarroll
Priority: major Milestone: 5.0.0-rc1
Component: OmeroFs Version: n.a.
Keywords: n.a. Cc: fs@…
Resources: n.a. Referenced By: n.a.
References: n.a. Remaining Time: 0.0d
Sprint: OMERO 5 Beta 2 (1)

Description

There is an issue of clients that do not have an implementation for the server's default checksum algorithm and are now handed an import process that is demanding to use it. After some consideration of use cases, and tradeoffs between what's easy and what's desirable, I would suggest that the interaction should be that,

  • the server returns to requiring the client to specify the checksum algorithm to create an import process
  • the client is still offered the getChecksumAlgorithms API call to find out which are available, so that it may be sure to select one that is supported server-side.

Either the client asks the server which algorithms are supported, and it chooses one, or it lets the server default apply as follows,

  1. rather than a single default, the server is configured with a list of supported algorithms sorted in order of preference
  2. the client tells the server which algorithms it supports
  3. the server tells the client which algorithm to set (the first in the list that the client supports) in requesting an import process.

Change History (7)

comment:1 Changed 11 years ago by mtbcarroll

This requires accompanying integration tests; I don't think we much test the algorithm choice stuff at all at present.

comment:2 Changed 11 years ago by mtbcarroll

  • Priority changed from minor to major

comment:3 Changed 10 years ago by mtbcarroll

  • Milestone changed from 5.0.0-beta1 to 5.0.0-beta2

It would be nice to get this in ASAP before much adoption because it will break imports between clients and servers that do and don't have this import API change.

comment:4 Changed 10 years ago by mtbcarroll

  • Status changed from new to accepted

comment:5 Changed 10 years ago by mtbcarroll

  • Sprint set to OMERO 5 Beta 2 (1)

comment:6 Changed 10 years ago by mtbcarroll

  • Resolution set to fixed
  • Status changed from accepted to closed

comment:7 Changed 10 years ago by Josh Moore <josh@…>

  • Remaining Time set to 0

(In [b9becb3d1a69dab30375724642bfef78172f5d54/ome.git] on branch develop) Merge pull request #1653 from mtbc/11202-negotiate-hasher

fix #11202: introduce suggestChecksumAlgorithm method to FS API

Note: See TracTickets for help on using tickets. You may also have a look at Agilo extensions to the ticket.

1.3.13-PRO © 2008-2011 Agilo Software all rights reserved (this page was served in: 0.68961 sec.)

We're Hiring!