Bug: Insight doesn't delete one of multiple ROIs, crashes on second attempt.

[spli]

1. Open an image.
2. Open the measurement/ROI dialog.
3. Create two ROIs.
4. Save the ROIs.
5. Right click on of the ROIs and delete. Only oenk ROI should be listed
6. Save the ROIs. The 'deleted' ROI re-appears.
7. Try to delete the ROI again. Insight will probably crash.

Note seen during ice35 gretzky testing with all three clients (ice 3.3, 3.4, 3.5). Following exception taken from OMERO.insight-5.0.0-beta1-176-8c0beca-ice33-b353-mac:

java.lang.Exception: Abnormal termination due to an uncaught exception.
java.lang.IllegalArgumentException: The method can only be invoked in the LOADING_ROI state.
	at org.openmicroscopy.shoola.agents.measurement.view.MeasurementViewerComponent.setLoadingFromServerClient(MeasurementViewerComponent.java:884)
	at org.openmicroscopy.shoola.agents.measurement.ServerSideROILoader.handleResult(ServerSideROILoader.java:109)
	at org.openmicroscopy.shoola.env.data.events.DSCallAdapter.eventFired(DSCallAdapter.java:90)
	at org.openmicroscopy.shoola.env.data.views.BatchCallMonitor$1.run(BatchCallMonitor.java:124)
	at java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:209)
	at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:708)
	at java.awt.EventQueue.access$400(EventQueue.java:82)
	at java.awt.EventQueue$2.run(EventQueue.java:669)
	at java.awt.EventQueue$2.run(EventQueue.java:667)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.AccessControlContext$1.doIntersectionPrivilege(AccessControlContext.java:87)
	at java.awt.EventQueue.dispatchEvent(EventQueue.java:678)
	at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:296)
	at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:211)
	at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:201)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:196)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:188)
	at java.awt.EventDispatchThread.run(EventDispatchThread.java:122)
Abnormal termination due to an uncaught exception.
java.lang.IllegalArgumentException: The method can only be invoked in the LOADING_ROI state.
	at org.openmicroscopy.shoola.agents.measurement.view.MeasurementViewerComponent.setLoadingFromServerClient(MeasurementViewerComponent.java:884)
	at org.openmicroscopy.shoola.agents.measurement.ServerSideROILoader.handleResult(ServerSideROILoader.java:109)
	at org.openmicroscopy.shoola.env.data.events.DSCallAdapter.eventFired(DSCallAdapter.java:90)
	at org.openmicroscopy.shoola.env.data.views.BatchCallMonitor$1.run(BatchCallMonitor.java:124)
	at java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:209)
	at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:708)
	at java.awt.EventQueue.access$400(EventQueue.java:82)
	at java.awt.EventQueue$2.run(EventQueue.java:669)
	at java.awt.EventQueue$2.run(EventQueue.java:667)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.AccessControlContext$1.doIntersectionPrivilege(AccessControlContext.java:87)
	at java.awt.EventQueue.dispatchEvent(EventQueue.java:678)
	at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:296)
	at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:211)
	at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:201)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:196)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:188)
	at java.awt.EventDispatchThread.run(EventDispatchThread.java:122)
Exception in thread "AWT-EventQueue-0"

	at org.openmicroscopy.shoola.env.ui.UserNotifierImpl.showErrorDialog(UserNotifierImpl.java:190)
	at org.openmicroscopy.shoola.env.ui.UserNotifierImpl.notifyError(UserNotifierImpl.java:292)
	at org.openmicroscopy.shoola.env.AbnormalExitHandler.doTermination(AbnormalExitHandler.java:147)
	at org.openmicroscopy.shoola.env.AbnormalExitHandler.terminate(AbnormalExitHandler.java:85)
	at org.openmicroscopy.shoola.env.AWTExceptionHanlder.handle(AWTExceptionHanlder.java:99)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
	at java.lang.reflect.Method.invoke(Method.java:597)
	at java.awt.EventDispatchThread.handleException(EventDispatchThread.java:412)
	at java.awt.EventDispatchThread.processException(EventDispatchThread.java:318)
	at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:312)
	at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:211)
	at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:201)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:196)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:188)
	at java.awt.EventDispatchThread.run(EventDispatchThread.java:122)

[pwalczysko]

Repeated the exception with

• Ice3.3 Insight and Ice3.3 server (gretzky) on re-test of this bug- just the exception and crash
• Ice 3.4 Insight and Ice 3.3 server (gretzky) - with exception & crash and (before the crash) "undeletable region" problem

[pwalczysko]

Upping to major, because after the exception, full crash of Insight follows.

[pwalczysko]

In my workflow, it turned out to be necessary to create 3 rectangular regions:

• Save the 3 regions
• Then delete the last one created by right-click onto the region in the image
• save regions again
• delete the one but last created, save again- ->. Then the crash happened.

[jburel]

Tested with today's build. I cannot reproduce it.

[mtbcarroll]

I probably fixed it in ​https://github.com/openmicroscopy/openmicroscopy/pull/1480.

[jburel]

Can you close the ticket in that case?