Bug: Automated GUI testing of Insight with SwingLibrary has surprising failure in popup menu

[mtbcarroll]

#11210 includes (albeit in a spread-out way) instructions for running a simple first test case on Insight with Robot Framework. There is a bad surprise: if we add a test to the end of the test-11214.rest attached to that ticket, to test which popup menu items on Orphaned Images are enabled, then there is an unexpected failure, shown by the attached log. The comments on #11210 include some initial investigation of this, but progress on that ticket will now move beyond this specific issue.

The source for SwingLibrary, Robot Framework, even Swing itself, is all available and quite readable, and the failure is easily reproduced, so this problem should certainly be solvable, but I am separating it out to its own narrow ticket because I don't want it to stop me doing other work on #11210 right now. Anybody should feel free to pick this one up.

[mtbcarroll]

In testing fixes to this perhaps add a test case for ​https://www.openmicroscopy.org/qa2/qa/feedback/7552/ viz.

When I select multiple images in the central panel using either the shift or command keys, I can later access a number of options using the right mouse button's contextual menu (eg set min/max)
However, if I select the same images by dragging a square around them, some of these options are not available.

[mtbcarroll]

execution log of failing script

[mtbcarroll]

minimal test case

[mtbcarroll]

What is enabled on context menus is an issue that Gus has been flagging as discrepancy between Insight and Web. So, between that and #11214, I should have another crack at this bug and hope that my luck is better this time.

[mtbcarroll]

Okay, here's an interesting thing: the popup menu created and shown by Insight is a org.openmicroscopy.shoola.agents.treeviewer.view.PopupMenu with a BevelBorder but the one found by Abbot is a javax.swing.JPopupMenu with an AquaMenuBorder.

[mtbcarroll]

The invoker of the Insight popup menu is the DnDTree but the invoker of the one found by Abbot is a JMenu.

[mtbcarroll]

Abbot does find the DnDTree; I wonder if AWTHierarchy.getComponents has a way to find the popup menu invoked by it.

[mtbcarroll]

Ah, it looks like AWTHierarchy.getComponents is finding only varieties of TreeCellRenderer under the DnDTree. I wonder where that other popup menu is coming from then.

JM, do you want to have a look at this issue? You might take a different line of enquiry that is rather more rapidly productive than mine seem to have been.

[mtbcarroll]

I have figured this out. The JMenuItemMatcher in Abbot matches either the path to the menu item or, crucially, just the text of the item itself. Despite my attempt to set the context to the tree viewer's BrowserUI panel the matcher was picking up the File|Import... from the main toolbar instead of the Import... I intended from the popup menu. This, I can devise a fix for.

[mtbcarroll]

Fixed by ​https://github.com/mtbc/openmicroscopy/commit/55351304738ceb5ec09906557c6335d8ee4b63e1 but will need a little extra work for testing submenus of popup menus.

[mtbcarroll]

Reported the problem in ​https://github.com/robotframework/SwingLibrary/issues/47

[Jean-Marie Burel <j.burel@…>]

(In [ffa06dbd08ecefde6923f9d4ca19e61784f5847e/ome.git] on branch develop) fix #11326 to address #11214: popup menu items enabled

[Jean-Marie Burel <j.burel@…>]

(In [a111201a1140c0c83517343e9899d7be5090b9fd/ome.git]on branches master, dev_4_4) fix #11326 to address #11214: popup menu items enabled