Task #11396 (closed)
Opened 6 years ago
Closed 5 years ago
Use python zipfile unstead of Popen in omego upgrade
| Reported by: | spli | Owned by: | spli |
|---|---|---|---|
| Priority: | minor | Milestone: | 5.x |
| Component: | General | Version: | 4.4.8 |
| Keywords: | n.a. | Cc: | |
| Resources: | n.a. | Referenced By: | n.a. |
| References: | n.a. | Remaining Time: | n.a. |
| Sprint: | n.a. |
Description (last modified by spli)
E.g. https://gist.github.com/manics/5661370#file-unzip_hudson_latest-py-L115
Also return a exit code failure if case the unzip fails, don't just call sys.exit(0).
Change History (3)
comment:1 Changed 6 years ago by jamoore
comment:2 Changed 6 years ago by jamoore
- Sprint Testing and Docs (2) deleted
Referencing ticket #11363 has changed sprint.
comment:3 Changed 5 years ago by spli
- Description modified (diff)
- Resolution set to fixed
- Status changed from new to closed
Note: See
TracTickets for help on using
tickets.
You may also have a look at Agilo extensions to the ticket.
I seem to remember there being a reason to not use zipfile, Simon, but if you can get it to work on all platforms, then +1 for not needing to configure ZIPARGS, etc.