Notice: In order to edit this ticket you need to be either: a Product Owner, The owner or the reporter of the ticket, or, in case of a Task not yet assigned, a team_member"

Task #11480 (closed)

Opened 6 years ago

Closed 6 years ago

Integration tests should be able to run remotely

Reported by: cblackburn Owned by: bpindelski
Priority: major Milestone: OMERO-4.4.9
Component: General Version: 4.4.8
Keywords: n.a. Cc: jamoore
Resources: n.a. Referenced By: n.a.
References: n.a. Remaining Time: n.a.
Sprint: n.a.

Description (last modified by cblackburn)

Some integration tests under both OmeroPy and OmeroJava write files direct to disk. This means the tests fail if run against a remote server. The obvious candidates are

components/tools/OmeroPy/test/integration/test_bfpixelsstoreexternal.py
components/tools/OmeroPy/test/integration/test_bfpixelsstoreinternal.py
components/tools/OmeroJava/test/integration/BfPixelBufferTest.java
components/tools/OmeroJava/test/integration/ExporterTest.java

but there may be others. The two Python cases could be deprecated as part of #11433 as the tests appear to be fully covered in the Java case.

Change History (6)

comment:1 Changed 6 years ago by cblackburn

  • Description modified (diff)

comment:2 Changed 6 years ago by bpindelski

The BfPixelBufferTest class might not be trivial to fix. It is indeed possible to remove the new File() code path and upload test files to a remote server using the service factory, but ultimately we end up calling the BfPixelBuffer ctor with a file name and the class is oblivious to any remote connections - it expects the file to be present locally. Maybe BfPixelsBufferTest should really be a type-of-unit test in omero-romio?

comment:3 Changed 6 years ago by jamoore

It would require a short review, but if all the tests are solely testing APIs that work in byte[] then there's likely little reason to have remoting in the loop, since we're quite confident that that's not going to go wrong. In which case, either a romio unit test or an internal server integration test would be possible.

comment:4 Changed 6 years ago by bpindelski

Josh: An initial (and probably final) fix is in https://github.com/bpindelski/openmicroscopy/tree/11480-remoting. I've ran the "integration" target of OmeroJava against a second laptop that was hosting the server instance on a different IP. All tests run fine. I no-one can come up with other corner cases, I'd consider this fixed and open a PR from my branch.

comment:6 Changed 6 years ago by bpindelski

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets. You may also have a look at Agilo extensions to the ticket.

1.3.13-PRO © 2008-2011 Agilo Software all rights reserved (this page was served in: 0.81457 sec.)

We're Hiring!