Task #11576 (closed)
Opened 11 years ago
Closed 10 years ago
Bug: xsd-fu sometimes generates invalid sources on Windows
| Reported by: | rleigh | Owned by: | rleigh |
|---|---|---|---|
| Priority: | major | Milestone: | 5.1.0 |
| Component: | Bio-Formats | Version: | 5.0.0-beta1 |
| Keywords: | n.a. | Cc: | jamoore |
| Resources: | n.a. | Referenced By: | n.a. |
| References: | n.a. | Remaining Time: | n.a. |
| Sprint: | n.a. |
Description
Genshi is generating broken sources on Windows (http://hudson.openmicroscopy.org.uk/job/OMERO-merge-develop-win/7/console). It’s leaving in trailing backslashes which are usually stripped out and failing due to the generated files being full of them. Presumably it’s looking for “
\r\n” rather than “
\n” on Windows, and breaking as a result. Or the newlines are being transformed on reading.
However, this doesn't affect all systems. Testing on Windows7 x64 with Python 2.6.8 (x84) and Genshi 0.7 works fine. But Server 2003 with Python 2.6.6 (i386) and ActiveState? Python with Genshi 0.7 does not.
This might not be something we can fix ourselves if the solution is just to upgrade python, but it's not yet clear what the cause of the problem is. Josh, would it be possible to upgrade python on this jenkins node? I don't want to break the pytables job that's running there--is that dependent upon this specific Python implementation or could it be replaced? This could wait until we have a new Windows node though.
Change History (5)
comment:1 Changed 11 years ago by jamoore
comment:2 Changed 10 years ago by jburel
- Milestone changed from 5.0.0-beta2 to 5.0.0-beta3
- Sprint OMERO 5 Beta 2 (1) deleted
Other things prevent from Building on windows. This is required more work.
Pushing to Beta3
comment:3 Changed 10 years ago by mlinkert
Have you checked if changing the Git settings so that 'core.autocrlf' is set to 'input' works? I know we discussed this a while back with respect to the Bio-Formats build alone; I'd assume that doing the same thing would help with the OMERO build.
comment:4 Changed 10 years ago by rleigh
I need to revisit the Windows builds of both Bio-Formats and OMERO. This should fix things. I'll reactivate/add the appropriate builds.
On the documentation side, I'll double-check what our advice currently is. I am a little concerned that we are (or were) recommending setting core.autocrlf system-wide rather than per-repository, which could have equally adverse effects on other git repos which require or expect alternative behaviour.
comment:5 Changed 10 years ago by rleigh
- Resolution set to fixed
- Status changed from new to closed
https://github.com/openmicroscopy/bioformats/pull/1207/ and https://github.com/openmicroscopy/bioformats/pull/1208 address the Windows build requirements in the docs. Not ideal, but documents the known workaround.
I don't think there will be a problem changing Python versions. It may require bumping some other dependencies though. Once the job is green, all should be good.