Task #11577 (closed)
ChecksumProviderFactory should list available algorithms
| Reported by: | mtbcarroll | Owned by: | mtbcarroll |
|---|---|---|---|
| Priority: | minor | Milestone: | 5.x |
| Component: | OmeroFs | Version: | 5.0.0-beta1 |
| Keywords: | n.a. | Cc: | fs@… |
| Resources: | n.a. | Referenced By: | n.a. |
| References: | n.a. | Remaining Time: | 0.0d |
| Sprint: | n.a. |
Description
For file uploads the client and server need to agree on a mutually supported checksum algorithm. In setting ImportSettings.checksumAlgorithm https://github.com/mtbc/openmicroscopy/commit/4b4c4e4bf574b15e21c5e8a6fe2f626ed44b4b06 has ImportLibrary.createImport assume that the client supports any algorithm that the server supports; for now, this is true, but may not be forever.
The client code could try using getProvider(ChecksumType) for every algorithm supported by the server to probe the client's factory's capabilities but best would be if ChecksumProviderFactory simply provided a method that lists the supported checksums; then createImport can use that and omit the current listChecksumAlgorithms API call to the server (which isn't the best of ideas, but will suffice until this ticket is resolved).
See #11202 for more background.
Change History (4)
comment:1 Changed 6 years ago by mtbcarroll
- Status changed from new to accepted
comment:2 Changed 6 years ago by mtbcarroll
- Resolution set to fixed
- Status changed from accepted to closed
comment:3 Changed 6 years ago by Mark Carroll <M.T.B.Carroll@…>
- Remaining Time set to 0
(In [92611d2d9fe279e2838ffd8bd1d18a209fffa3bb/ome.git] on branch develop) fix #11577: have checksum provider list available hashers
comment:4 Changed 6 years ago by Josh Moore <josh@…>
(In [23e53df205caa46d4589f7aee76143fb39ac328a/ome.git] on branch develop) Merge pull request #1915 from mtbc/trac-11577-available-hashers
fix #11577: have checksum provider list available hashers
Fixed by https://github.com/openmicroscopy/openmicroscopy/pull/1915.