Task #11597 (closed)
Opened 6 years ago
Closed 5 years ago
Bug: maven build uses git unconditionally
| Reported by: | rleigh | Owned by: | mlinkert |
|---|---|---|---|
| Priority: | major | Milestone: | 5.x |
| Component: | Bio-Formats | Version: | 5.0.0-beta1 |
| Keywords: | n.a. | Cc: | |
| Resources: | n.a. | Referenced By: | n.a. |
| References: | n.a. | Remaining Time: | n.a. |
| Sprint: | n.a. |
Description (last modified by rleigh)
The maven build fails when git is not present, or if git is present but not building in a git repository. It's using git unconditionally without checking for the tool presence, and it's also using git when not in a git repository.
git should only be run if the following conditions are met:
- git is present and executable
- .git directory present in the project root
Change History (5)
comment:1 Changed 6 years ago by rleigh
- Component changed from General to Bio-Formats
- Owner set to mlinkert
- Summary changed from maven build uses git unconditionally to Bug: maven build uses git unconditionally
comment:2 Changed 6 years ago by rleigh
- Description modified (diff)
comment:3 Changed 6 years ago by jburel
comment:4 Changed 6 years ago by jburel
- Milestone changed from 5.0.0-beta2 to 5.0.0
Moving to 5.0.0 for now.
comment:5 Changed 5 years ago by rleigh
- Resolution set to fixed
- Status changed from new to closed
Fixed on dev_5_0 now.
Referencing ticket #11593 has changed sprint.