Task #11598 (closed)
Opened 6 years ago
Closed 6 years ago
Bug: cmake build uses git unconditionally
| Reported by: | rleigh | Owned by: | rleigh |
|---|---|---|---|
| Priority: | major | Milestone: | 5.x |
| Component: | Bio-Formats | Version: | 5.0.0-beta1 |
| Keywords: | n.a. | Cc: | |
| Resources: | n.a. | Referenced By: | n.a. |
| References: | n.a. | Remaining Time: | n.a. |
| Sprint: | n.a. |
Description
The cmake build fails when git is not present, or if git is present but not building in a git repository. It's using git unconditionally without checking for the tool presence, and it's also using git when not in a git repository.
git should only be run if the following conditions are met:
- git is present and executable
- .git directory present in the project root
Change History (3)
comment:1 Changed 6 years ago by jburel
comment:2 Changed 6 years ago by jburel
- Milestone changed from 5.0.0-beta2 to 5.0.0
comment:3 Changed 6 years ago by rleigh
- Resolution set to fixed
- Status changed from new to closed
As for the ant case, git is no longer run if the .git directory is not present in https://github.com/openmicroscopy/bioformats/pull/884.
Note: See
TracTickets for help on using
tickets.
You may also have a look at Agilo extensions to the ticket.
Referencing ticket #11593 has changed sprint.