Task #11603 (closed)
Opened 6 years ago
Closed 6 years ago
Bug: ant build uses git unconditionally
| Reported by: | rleigh | Owned by: | rleigh |
|---|---|---|---|
| Priority: | major | Milestone: | 5.x |
| Component: | Deployment | Version: | 5.0.0-beta1 |
| Keywords: | n.a. | Cc: | |
| Resources: | n.a. | Referenced By: | n.a. |
| References: | n.a. | Remaining Time: | n.a. |
| Sprint: | n.a. |
Description
The ant build fails when git is not present, and building in a git repository. It's using git unconditionally without checking for the tool presence. It's also using git when a .git directory is not present in the project root.
git should only be run if the following conditions are met:
git is present and executable
.git directory present in the project root
See build.xml and components/antlib/resources/global.xml.
Change History (4)
comment:1 Changed 6 years ago by jburel
comment:2 Changed 6 years ago by jburel
- Milestone changed from 5.0.0-beta2 to 5.0.0
comment:3 Changed 6 years ago by rleigh
- Owner set to rleigh
Fixed in https://github.com/openmicroscopy/openmicroscopy/pull/1712 git is now only run when in the git tree, when building from a release zip it's not run at all.
comment:4 Changed 6 years ago by rleigh
- Resolution set to fixed
- Status changed from new to closed
Note: See
TracTickets for help on using
tickets.
You may also have a look at Agilo extensions to the ticket.
Referencing ticket #11593 has changed sprint.