Task #11635 (closed)
Opened 6 years ago
Closed 5 years ago
RFE: configure checksum through ImportConfig?
| Reported by: | mtbcarroll | Owned by: | jburel |
|---|---|---|---|
| Priority: | minor | Milestone: | 5.x |
| Component: | OmeroFs | Version: | n.a. |
| Keywords: | n.a. | Cc: | fs@… |
| Resources: | n.a. | Referenced By: | n.a. |
| References: | n.a. | Remaining Time: | n.a. |
| Sprint: | n.a. |
Description (last modified by mtbcarroll)
Should ImportConfig have a field through which the client can specify the checksum algorithm to be used? (Maybe also ImportContainer so that createImport can use it.)
(I'm happy to add it if it's decided it should be done.)
Change History (4)
comment:1 Changed 6 years ago by mtbcarroll
- Description modified (diff)
comment:2 Changed 6 years ago by jburel
comment:3 Changed 6 years ago by mtbcarroll
Perhaps ManagedRepository was the wrong class in which to put listChecksumAlgorithms and suggestChecksumAlgorithm; should they be in RawFileStore instead?
For non-import uploads RawFileBean calculates the hash according to the algorithm set in hasher for the OriginalFile indicated in the call to setFileId(final long fileId) so hopefully that can be useful for other kinds of upload.
I think that methods like Repository.file still hard-code to SHA1.
comment:4 Changed 5 years ago by mtbcarroll
- Resolution set to fixed
- Status changed from new to closed
This looks to me to be solved with ImportSettings.checksumAlgorithm and the API methods of ManagedRepository that assist in checksum algorithm selection.
We need to have a way of finding the available algorithm
and a way to set them, not only for import.
I will use a different algo if I am uploading an annotation for example