Task #11654 (closed)
Bug: ImportLibrary.importImage shouldn't fail in finally
Reported by: | jamoore | Owned by: | mtbcarroll |
---|---|---|---|
Priority: | critical | Milestone: | 5.0.0-rc1 |
Component: | Import | Version: | 4.4.9 |
Keywords: | n.a. | Cc: | java@… |
Resources: | n.a. | Referenced By: | n.a. |
References: | n.a. | Remaining Time: | 0.0d |
Sprint: | n.a. |
Description
See:
- https://www.openmicroscopy.org/qa2/qa/feedback/7686/
- https://github.com/openmicroscopy/openmicroscopy/blob/v.4.4.9/components/blitz/src/ome/formats/importer/ImportLibrary.java#L769
If an exception is throw during importImage() the attempt to reset the store in the finally should be protected by a catch(Throwable) and shouldn't fail which just hides the original point of failure. An error can be logged if necessary.
Change History (3)
comment:1 Changed 10 years ago by mtbcarroll
- Owner set to mtbcarroll
- Status changed from new to accepted
comment:2 Changed 10 years ago by mtbcarroll
- Resolution set to fixed
- Status changed from accepted to closed
comment:3 Changed 10 years ago by Josh Moore <josh@…>
- Remaining Time set to 0
(In [e21924256b26706e077674dc0932289c5e479d86/ome.git] on branch develop) Merge pull request #1739 from mtbc/trac-11654-importer-catches
fix #11654: adjust try / catch around import library operations
Fixed by https://github.com/openmicroscopy/openmicroscopy/pull/1739.