Warning: Can't synchronize with repository "(default)" (/home/git/ome.git does not appear to be a Git repository.). Look in the Trac log for more information.
Notice: In order to edit this ticket you need to be either: a Product Owner, The owner or the reporter of the ticket, or, in case of a Task not yet assigned, a team_member"

Task #11654 (closed)

Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

Bug: ImportLibrary.importImage shouldn't fail in finally

Reported by: jamoore Owned by: mtbcarroll
Priority: critical Milestone: 5.0.0-rc1
Component: Import Version: 4.4.9
Keywords: n.a. Cc: java@…
Resources: n.a. Referenced By: n.a.
References: n.a. Remaining Time: 0.0d
Sprint: n.a.

Description

See:

If an exception is throw during importImage() the attempt to reset the store in the finally should be protected by a catch(Throwable) and shouldn't fail which just hides the original point of failure. An error can be logged if necessary.

Change History (3)

comment:1 Changed 10 years ago by mtbcarroll

  • Owner set to mtbcarroll
  • Status changed from new to accepted

comment:2 Changed 10 years ago by mtbcarroll

  • Resolution set to fixed
  • Status changed from accepted to closed

comment:3 Changed 10 years ago by Josh Moore <josh@…>

  • Remaining Time set to 0

(In [e21924256b26706e077674dc0932289c5e479d86/ome.git] on branch develop) Merge pull request #1739 from mtbc/trac-11654-importer-catches

fix #11654: adjust try / catch around import library operations

Note: See TracTickets for help on using tickets. You may also have a look at Agilo extensions to the ticket.

1.3.13-PRO © 2008-2011 Agilo Software all rights reserved (this page was served in: 0.62208 sec.)

We're Hiring!