Task #11726 (closed)
Add jshint to travis
| Reported by: | jamoore | Owned by: | sbesson |
|---|---|---|---|
| Priority: | major | Milestone: | OMERO-5.1.4 |
| Component: | Deployment | Version: | 4.4.9 |
| Keywords: | n.a. | Cc: | aknab, sbesson, web-team@… |
| Resources: | n.a. | Referenced By: | n.a. |
| References: | n.a. | Remaining Time: | n.a. |
| Sprint: | n.a. |
Description
Along with Sebastien's recent addition of flake8 to travis, jslint should be invoked on .js files for each PR (once an initial cleanup is done)
See:
Change History (8)
comment:1 Changed 10 years ago by wmoore
comment:2 Changed 10 years ago by jamoore
- Summary changed from Add jslint to travis to Add jshint to travis
comment:3 Changed 9 years ago by jamoore
- Milestone changed from Testing2 to 5.1.4
Might be something to look at soon.
comment:4 Changed 9 years ago by sbesson
- Owner set to sbesson
- Status changed from new to accepted
comment:5 Changed 9 years ago by sbesson
Preliminary branch enabling jshint on Travis is pushed to https://github.com/sbesson/openmicroscopy/tree/jshint. See notably https://travis-ci.org/sbesson/openmicroscopy/jobs/72516530 for the resulting Travis build.
For the jshinting effort, is it worth converting this ticket into a checklist on a Trello card.
comment:6 Changed 9 years ago by jamoore
gfi
comment:7 Changed 9 years ago by sbesson
- Resolution set to fixed
- Status changed from accepted to closed
comment:8 Changed 9 years ago by jamoore
- Milestone changed from 5.1.4 to OMERO-5.1.4
Splitting 5.1.4 due to milestone decoupling
Note: See
TracTickets for help on using
tickets.
You may also have a look at Agilo extensions to the ticket.
previous discussions seemed to favour jshint (less strict) over jslint - https://github.com/openmicroscopy/openmicroscopy/pull/388