SecuritySystem needs to know when user is in active share

[atarkowska]

SecuritySystem needs to know when user is in active share and not allow to set Transactional(readOnly = false)

[atarkowska]

omero.SecurityViolation: exception ::omero::SecurityViolation
{
    serverStackTrace = ome.conditions.SecurityViolation: Creation is not allowed while in share.
	at ome.security.sharing.SharingACLVoter.throwDisabled(SharingACLVoter.java:102)
	at ome.security.sharing.SharingACLVoter.throwCreationViolation(SharingACLVoter.java:80)
	at ome.security.CompositeACLVoter.throwCreationViolation(CompositeACLVoter.java:78)
	at ome.security.ACLEventListener.onPreInsert(ACLEventListener.java:114)
	at org.hibernate.action.EntityInsertAction.preInsert(EntityInsertAction.java:160)
	at org.hibernate.action.EntityInsertAction.execute(EntityInsertAction.java:53)
	at org.hibernate.engine.ActionQueue.execute(ActionQueue.java:279)
	at org.hibernate.engine.ActionQueue.executeActions(ActionQueue.java:263)
	at org.hibernate.engine.ActionQueue.executeActions(ActionQueue.java:167)
	at org.hibernate.event.def.AbstractFlushingEventListener.performExecutions(AbstractFlushingEventListener.java:298)
	at org.hibernate.event.def.DefaultFlushEventListener.onFlush(DefaultFlushEventListener.java:27)
	at org.hibernate.impl.SessionImpl.flush(SessionImpl.java:1000)
	at org.springframework.orm.hibernate3.HibernateTemplate$28.doInHibernate(HibernateTemplate.java:888)
	at org.springframework.orm.hibernate3.HibernateTemplate.doExecute(HibernateTemplate.java:419)
	at org.springframework.orm.hibernate3.HibernateTemplate.executeWithNativeSession(HibernateTemplate.java:374)
	at org.springframework.orm.hibernate3.HibernateTemplate.flush(HibernateTemplate.java:886)
	at ome.logic.UpdateImpl.afterUpdate(UpdateImpl.java:256)
	at ome.logic.UpdateImpl.doAction(UpdateImpl.java:267)
	at ome.logic.UpdateImpl.saveAndReturnObject(UpdateImpl.java:127)
	at ome.security.basic.BasicSecuritySystem.loadEventContext(BasicSecuritySystem.java:343)
	at ome.security.basic.EventHandler.invoke(EventHandler.java:94)
	at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:171)
	at ome.tools.hibernate.SessionHandler.doStateful(SessionHandler.java:182)
	at ome.tools.hibernate.SessionHandler.invoke(SessionHandler.java:166)
	at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:171)
	at org.springframework.transaction.interceptor.TransactionInterceptor.invoke(TransactionInterceptor.java:106)
	at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:171)
	at ome.tools.hibernate.ProxyCleanupFilter$Interceptor.invoke(ProxyCleanupFilter.java:169)
	at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:171)
	at ome.services.util.ServiceHandler.invoke(ServiceHandler.java:93)
	at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:171)
	at org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:204)
	at $Proxy55.setPixelsId(Unknown Source)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
	at java.lang.reflect.Method.invoke(Method.java:585)
	at org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:310)
	at org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:182)
	at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:149)
	at ome.security.basic.BasicSecurityWiring.invoke(BasicSecurityWiring.java:78)
	at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:171)
	at ome.services.blitz.fire.AopContextInitializer.invoke(AopContextInitializer.java:35)
	at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:171)
	at org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:204)
	at $Proxy55.setPixelsId(Unknown Source)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
	at java.lang.reflect.Method.invoke(Method.java:585)
	at ome.services.blitz.util.IceMethodInvoker.callOrClose(IceMethodInvoker.java:257)
	at ome.services.blitz.util.IceMethodInvoker.invoke(IceMethodInvoker.java:179)
	at ome.services.throttling.Callback.run(Callback.java:55)
	at ome.services.throttling.InThreadThrottlingStrategy.callInvokerOnRawArgs(InThreadThrottlingStrategy.java:37)
	at ome.services.blitz.impl.AbstractAmdServant.callInvokerOnRawArgs(AbstractAmdServant.java:114)
	at ome.services.blitz.impl.ThumbnailStoreI.setPixelsId_async(ThumbnailStoreI.java:132)
	at omero.api._ThumbnailStoreTie.setPixelsId_async(_ThumbnailStoreTie.java:169)
	at omero.api._ThumbnailStoreDisp.___setPixelsId(_ThumbnailStoreDisp.java:211)
	at omero.api._ThumbnailStoreDisp.__dispatch(_ThumbnailStoreDisp.java:634)
	at IceInternal.Incoming.invoke(Incoming.java:166)
	at Ice.ConnectionI.invokeAll(ConnectionI.java:2045)
	at Ice.ConnectionI.message(ConnectionI.java:977)
	at IceInternal.ThreadPool.run(ThreadPool.java:575)
	at IceInternal.ThreadPool.access$100(ThreadPool.java:12)
	at IceInternal.ThreadPool$EventHandlerThread.run(ThreadPool.java:951)

    serverExceptionClass = ome.conditions.SecurityViolation
    message = Creation is not allowed while in share.
}

[atarkowska]

r3602

[atarkowska]

related ticekt #1178

[jmoore]

Ola, try out r3611. test/integration/ishare.py seems to work fine, but I didn't test anything else.

[jmoore]

r3615 has another version for you to try, Ola. See the test I added to ishare.py if you'd like to extend it.

[atarkowska]

Works fine