Task #11800 (closed)
Opened 6 years ago
Closed 6 years ago
Url tag from future in 4.4
| Reported by: | wmoore | Owned by: | wmoore |
|---|---|---|---|
| Priority: | major | Milestone: | 5.0.0 |
| Component: | Documentation | Version: | 4.4.9 |
| Keywords: | n.a. | Cc: | python-team@… |
| Resources: | n.a. | Referenced By: | n.a. |
| References: | n.a. | Remaining Time: | n.a. |
| Sprint: | n.a. |
Description
See https://github.com/openmicroscopy/openmicroscopy/pull/1773#issuecomment-29388272
Not such a big deal for our own code (I think we can manage to update url syntax in PR rebases) but certainly for anyone who has an app they want to work with OMERO 4.4. and OMERO 5.0 - it would be handy if either OMERO 4.4. supports {% url "quoted" %} syntax OR we document how to make the app compatible with both (if that's possible) by doing the {% load url from future %} or settings approach.
Change History (4)
comment:1 Changed 6 years ago by wmoore
- Component changed from Web to Documentation
- Milestone changed from OMERO-4.4.10 to 5.0.0
- Priority changed from critical to major
comment:2 Changed 6 years ago by hflynn
Does https://github.com/openmicroscopy/ome-documentation/pull/615 PR submitted by Douglas fix this ticket or is more work still needed?
comment:3 Changed 6 years ago by spli
I think that PR covers everything.
comment:4 Changed 6 years ago by wmoore
- Resolution set to fixed
- Status changed from new to closed
Yes - Everything is covered by that PR, thanks!
Adding this (E.g. to webadmin/views.py)
import django.template django.template.add_to_builtins('django.templatetags.future')means that EVERY {% url "name" %} tag needs quotes, which would mean too many changes for 4.4.
So we should probably go for the documentation solution:
Add this line at the top of templates that use quotes in url tag, then they can be used for 4.4 OMERO.
{% load url from future %}This should probably go in OMERO 5.0 docs, rather than 4.4?
As there are other issues to making an app compatible between 4.4 & 5.0(E.g. different imports) the docs for this will also need a bit of thought.
Anyway - this won't be part of 4.4.10. Pushing...