Warning: Can't synchronize with repository "(default)" (/home/git/ome.git does not appear to be a Git repository.). Look in the Trac log for more information.
Notice: In order to edit this ticket you need to be either: a Product Owner, The owner or the reporter of the ticket, or, in case of a Task not yet assigned, a team_member"

Task #11817 (closed)

Opened 8 years ago

Closed 8 years ago

Bug: unclear that tag IDs are expected

Reported by: jamoore Owned by: sbesson
Priority: major Milestone: 5.0.0-rc1
Component: Client Version: 5.0.0-beta2-RC3
Keywords: n.a. Cc: shart
Resources: n.a. Referenced By: n.a.
References: n.a. Remaining Time: n.a.
Sprint: n.a.

Description

bin/omero tag createset: error: unrecognized arguments: JoshSet
jamoore@blue:/tmp/OMERO.server-5.0.0-beta2-RC3-ice35-b9$ bin/omero tag createset --name JoshSet --tag A B C D
Please enter a description for this tag set: Don't make me enter a description! Oh, man!
Traceback (most recent call last):
  File "bin/omero", line 125, in <module>
    rv = omero.cli.argv()
  File "/tmp/OMERO.server-5.0.0-beta2-RC3-ice35-b9/lib/python/omero/cli.py", line 1195, in argv
    cli.invoke(args[1:])
  File "/tmp/OMERO.server-5.0.0-beta2-RC3-ice35-b9/lib/python/omero/cli.py", line 745, in invoke
    stop = self.onecmd(line, previous_args)
  File "/tmp/OMERO.server-5.0.0-beta2-RC3-ice35-b9/lib/python/omero/cli.py", line 814, in onecmd
    self.execute(line, previous_args)
  File "/tmp/OMERO.server-5.0.0-beta2-RC3-ice35-b9/lib/python/omero/cli.py", line 894, in execute
    args.func(args)
  File "/tmp/OMERO.server-5.0.0-beta2-RC3-ice35-b9/lib/python/omero/plugins/tag.py", line 499, in createset
    link.child = TagAnnotationI(rlong(long(t)), False)
ValueError: invalid literal for long() with base 10: 'A'
jamoore@blue:/tmp/OMERO.server-5.0.0-beta2-RC3-ice35-b9$ 

Change History (3)

comment:1 Changed 8 years ago by jamoore

Minor rfe: requiring a description is a bit frustrating.

comment:2 Changed 8 years ago by sbesson

  • Status changed from new to accepted

comment:3 Changed 8 years ago by sbesson

  • Resolution set to fixed
  • Status changed from accepted to closed

See https://github.com/openmicroscopy/openmicroscopy/pull/1903.
Corresponding tests are under test/unit/clitest as the command should now fail-fast with wrong input type.

As for the RFE, waiting to have Sam's opinion on it as he is the one who wrote it in the first place and we do not want to break any existing usage.

Note: See TracTickets for help on using tickets. You may also have a look at Agilo extensions to the ticket.

1.3.13-PRO © 2008-2011 Agilo Software all rights reserved (this page was served in: 0.65904 sec.)

We're Hiring!