Bug: fail to remove tag

[jamoore]

• As ejdavis using gretzky/ns
• In Firefox on Mac
• Find an image with a tag
• Click on the small X by the tag name
• Server Error: 500

  Traceback (most recent call last):
  
    File "/home/omero/OMERO-CURRENT/lib/python/django/core/handlers/base.py", line 114, in get_response
      response = wrapped_callback(request, *callback_args, **callback_kwargs)
  
    File "/home/omero/OMERO-CURRENT/lib/python/omeroweb/decorators.py", line 387, in wrapped
      retval = f(request, *args, **kwargs)
  
    File "/home/omero/OMERO-CURRENT/lib/python/omeroweb/decorators.py", line 434, in wrapper
      context = f(request, *args, **kwargs)
  
    File "/home/omero/OMERO-CURRENT/lib/python/omeroweb/webclient/views.py", line 1597, in manage_action_containers
      parents = request.REQUEST['parent']     # E.g. image-123  or image-1|image-2
  
    File "/home/omero/OMERO-CURRENT/lib/python/django/utils/datastructures.py", line 29, in __getitem__
      raise KeyError(key)
  
  KeyError: 'parent'
  
  
  <WSGIRequest
  path:/omero/webclient/action/remove/tag/276778/,
  GET:<QueryDict: {}>,
  POST:<QueryDict: {}>,
  COOKIES:{'sessionid': '....'},
  META:{'CONTENT_LENGTH': '28',
   'CONTENT_TYPE': 'application/javascript; charset=UTF-8',
   'DOCUMENT_ROOT': '/htdocs',
   'GATEWAY_INTERFACE': 'CGI/1.1',
   'HTTPS': 'on',
   'HTTP_ACCEPT': 'application/json, text/javascript, */*; q=0.01',
   'HTTP_ACCEPT_ENCODING': 'gzip, deflate',
   'HTTP_ACCEPT_LANGUAGE': 'en-US,en;q=0.5',
   'HTTP_CACHE_CONTROL': 'no-cache',
   'HTTP_CONNECTION': 'keep-alive',
   'HTTP_REFERER': 'https://gretzky.openmicroscopy.org.uk/omero/webclient/userdata/',
   'HTTP_USER_AGENT': 'Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:19.0) Gecko/20100101 Firefox/19.0',
   'HTTP_X_REQUESTED_WITH': 'XMLHttpRequest',
   'PATH': '/usr/local/bin:/usr/bin:/bin',
   'PATH_INFO': u'/webclient/action/remove/tag/276778/',
   'PATH_TRANSLATED': '/htdocs/webclient/action/remove/tag/276778/',
   'QUERY_STRING': '',
   'REMOTE_ADDR': '77.183.151.115',
   'REMOTE_PORT': '60467',
   'REQUEST_METHOD': 'POST',
   'REQUEST_URI': '/omero/webclient/action/remove/tag/276778/',
   'SCRIPT_FILENAME': '/home/omero/OMERO-CURRENT/var/omero.fcgi',
   'SCRIPT_NAME': u'/omero',
   'SCRIPT_URI': 'https://gretzky.openmicroscopy.org.uk/omero/webclient/action/remove/tag/276778/',
   'SCRIPT_URL': '/omero/webclient/action/remove/tag/276778/',
   'SERVER_ADDR': '134.36.66.9',
   'SERVER_ADMIN': '[no address given]',
   'SERVER_NAME': 'gretzky.openmicroscopy.org.uk',
   'SERVER_PORT': '443',
   'SERVER_PROTOCOL': 'HTTP/1.1',
   'SERVER_SIGNATURE': '<address>Apache/2.2.14 (Ubuntu) Server at gretzky.openmicroscopy.org.uk Port 443</address>\n',
   'SERVER_SOFTWARE': 'Apache/2.2.14 (Ubuntu)',
   'SSL_TLS_SNI': 'gretzky.openmicroscopy.org.uk',
   'wsgi.errors': <flup.server.fcgi_base.TeeOutputStream object at 0x47a4c90>,
   'wsgi.input': <flup.server.fcgi_base.InputStream object at 0x47a4a90>,
   'wsgi.multiprocess': True,
   'wsgi.multithread': False,
   'wsgi.run_once': False,
   'wsgi.url_scheme': 'https',
   'wsgi.version': (1, 0)}>
  

[jamoore]

from log bot:

ERROR: gretzky log/OMEROweb_request.log:
2013-12-12 11:50:48,662 ERROR [                          django.request] (proc.28242) handle_uncaught_exception:226 Internal Server Error: /omero/webclient/action/remove/tag/276778/
Traceback (most recent call last):
  File "/home/omero/OMERO-CURRENT/lib/python/django/core/handlers/base.py", line 114, in get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "/home/omero/OMERO-CURRENT/lib/python/omeroweb/decorators.py", line 387, in wrapped
    retval = f(request, *args, **kwargs)
  File "/home/omero/OMERO-CURRENT/lib/python/omeroweb/decorators.py", line 434, in wrapper
    context = f(request, *args, **kwargs)
  File "/home/omero/OMERO-CURRENT/lib/python/omeroweb/webclient/views.py", line 1597, in manage_action_containers
    parents = request.REQUEST['parent']     # E.g. image-123  or image-1|image-2
  File "/home/omero/OMERO-CURRENT/lib/python/django/utils/datastructures.py", line 29, in __getitem__
    raise KeyError(key)
KeyError: 'parent'

[jamoore]

sorry, typo

[wmoore]

This is due to ​http://stackoverflow.com/questions/15230627/data-not-sent-using-jquery-ajax-to-a-django-view which could affect a whole load of AJAX calls. Same issue as #11819, but probably we need a lot more testing (as well as search & replace of contentType: ).

[wmoore]

​https://github.com/openmicroscopy/openmicroscopy/pull/1900

[Will Moore <will@…>]

(In [e3804f51a8dc5062ab877d666d952841189f4b40/ome.git] on branch develop) Fix Tag removal contentType: See #11821