Task #11827 (closed)
Opened 10 years ago
Closed 10 years ago
Bug: C++ pixel buffer implementation
| Reported by: | rleigh | Owned by: | rleigh |
|---|---|---|---|
| Priority: | minor | Milestone: | Unscheduled |
| Component: | Bio-Formats | Version: | 5.0.0-beta2-RC3 |
| Keywords: | cpp | Cc: | |
| Resources: | n.a. | Referenced By: | n.a. |
| References: | n.a. | Remaining Time: | n.a. |
| Sprint: | n.a. |
Description
The Java implementation uses byte[] arrays. These have been replicated in C++ as std::vector<uint8_t>. However, this approach is fairly limited, since we could make it use the correct pixel type for ease of use and type-safety, as well as having correct dimensions of the contained pixel values to permit passing it to other methods etc.
Suggestion:
- PixelBufferBase? base class from which PixelBuffer?<T> is derived. The latter is templated, but the untemplated base means the buffer can be passed to non-templated function.
- The base class can contain generic metadata such as the dimensions and sizes of the buffer
- Plus templated accessors (which could include index operators)
This can be passed around to openByte/saveBytes and the metadata binData methods, used internally by readers, etc.
Change History (4)
comment:1 Changed 10 years ago by rleigh
- Owner changed from mlinkert to rleigh
comment:2 Changed 10 years ago by rleigh
- Keywords cpp added
Version 0, edited 10 years ago
by rleigh
(next)
comment:3 Changed 10 years ago by rleigh
- Status changed from new to accepted
comment:4 Changed 10 years ago by rleigh
- Resolution set to fixed
- Status changed from accepted to closed
PR ready now.
Note: See
TracTickets for help on using
tickets.
You may also have a look at Agilo extensions to the ticket.
https://github.com/openmicroscopy/bioformats/pull/1204