Task #11834 (closed)
BUG: jpeg, png and tiff download failure
| Reported by: | pwalczysko | Owned by: | jburel |
|---|---|---|---|
| Priority: | critical | Milestone: | 5.0.0 |
| Component: | Insight | Version: | 4.4.9 |
| Keywords: | n.a. | Cc: | ux@…, |
| Resources: | n.a. | Referenced By: | n.a. |
| References: | n.a. | Remaining Time: | 0.0d |
| Sprint: | n.a. |
Description
In Insight, dev_4_4 (OMERO4) line, when plate some wells of the plate are selected and the Save as.. > JPEG or Save as.. > PNG and Save as... > TIFF is executed, this action fails silently.
The silent failure is there also when the plate itself is selected (the menu items are not greyed out).
On develop (OMERO5) line, this action is executed as expected and uses Batch image export script creating a zip when particular wells (single or multiple) are selected. When plate is selected (as opposed to wells), these options are greyed out.
Reported via Forum https://www.openmicroscopy.org/community/viewtopic.php?f=4&t=7367.
Change History (9)
comment:1 Changed 10 years ago by pwalczysko
- Milestone changed from 5.0.0-beta2 to OMERO-4.4.7
- Sprint changed from OMERO 5 Beta 2 (1) to 2013-02-12 (5)
comment:2 Changed 10 years ago by pwalczysko
- Milestone changed from OMERO-4.4.7 to OMERO-4.4.10
- Sprint 2013-02-12 (5) deleted
comment:3 Changed 10 years ago by mtbcarroll
- Owner changed from jburel to mtbcarroll
- Status changed from new to accepted
comment:4 Changed 10 years ago by mtbcarroll
comment:5 Changed 10 years ago by mtbcarroll
From agents.metadata.editor.EditorModel, given a selected run I wonder what the easiest way is of obtaining its well samples.
comment:6 Changed 10 years ago by mtbcarroll
- Milestone changed from OMERO-4.4.10 to 5.0.0
- Owner changed from mtbcarroll to jburel
Okay, this now works for when "some wells of the plate are selected", and we will be freezing for 4.4.10 so "when the plate itself is selected" may have to wait.
There are some interesting questions here, though. I don't know how best to do the relevant container hierarchy navigation from EditorModel, but with some help there I could probably make more progress on this ticket at a later date. Or, perhaps it would be better to move that logic into the batch export script itself so that other clients can make use of it. (I notice that parts of PojosImpl are limited in what hierarchy navigation they can do; perhaps expanding the container service's capabilities might be a good help.)
comment:7 Changed 10 years ago by jburel
- Resolution set to fixed
- Status changed from accepted to closed
comment:8 Changed 10 years ago by mtbcarroll
See #11895 for some issues arising from the above.
comment:9 Changed 10 years ago by jean-marie burel <j.burel@…>
- Remaining Time set to 0
(In [255dad1c2983ee0e976809ad09feae45ef08e5ab/ome.git] on branch dev_4_4) Merge pull request #1933 from mtbc/trac-11834-save-well-image
fix #11834: wells can be batch-exported
https://github.com/openmicroscopy/openmicroscopy/pull/1933 fixes this for selecting wells. However, what is the expected behavior when one chooses plates or runs? For instance, if I select a plate, do I save only the samples from "orphaned" wells in that plate but not in the runs underneath it (a plate may have both kinds of well), or do I include the well samples from every run under the plate? (I will have to check to what extent these "underneath" things are even already "loaded" into the client if we haven't yet expanded the node.) I also wonder how well the naming of image files in the zip archives copes with having multiple samples in the same well, whether from the same run or different runs in the plate. Basically, I'm concerned that might be too large a can of worms for 4.4.10.
A separate issue is that the client oddly asks for a local save location, but then just attaches the zip server-side instead; perhaps there is already a ticket to either actually do a download or eliminate the file dialog.