Task #11857 (accepted)
Opened 11 years ago
Last modified 9 years ago
BUG: Cannot break import of plate
Reported by: | pwalczysko | Owned by: | jamoore |
---|---|---|---|
Priority: | critical | Milestone: | OME-Files |
Component: | Client | Version: | 5.0.0-rc1 |
Keywords: | n.a. | Cc: | ux@…, fs@… |
Resources: | n.a. | Referenced By: | n.a. |
References: | n.a. | Remaining Time: | n.a. |
Sprint: | n.a. |
Description
In Insight, import data_repo/public/images/HCS/INCELL2000 - select first subfolder there and import.
When trying to cancel or cancel all during the scanning phase (fairly early after import started, ~2 mins, the cancelling action is being shown as proceeding in Importer in the line, but the spinner is still spinning (both in importer and Data Manager). See screenshots.
Importer can be closed, but the Insight as a whole cannot be Quitted (Force Quit necessary).
Attachments (6)
Change History (30)
Changed 11 years ago by pwalczysko
Changed 11 years ago by pwalczysko
Changed 11 years ago by pwalczysko
Changed 11 years ago by pwalczysko
Changed 11 years ago by pwalczysko
comment:1 Changed 11 years ago by jamoore
comment:2 Changed 11 years ago by pwalczysko
Noted another phase where the Cancel process is not smooth: the test_images_good/lei/050118.lei has on FS a long-ish "preparing upload" phase, during which the Cancel button is not greyed out, but if you press it , nothing happens.
comment:3 Changed 11 years ago by jamoore
- Owner set to jamoore
- Status changed from new to accepted
Starting to look at this now that the inplace import API & hooks are in place.
comment:4 Changed 11 years ago by jamoore
Uploaded screenshot which shows a grayed "cancel" button on upload. This may not be the correct location for the information, but I wanted to capture it while testing this issue.
Looking at the rest of Petr's feedback, it looks 1) these are largely state-issues (when can X be pressed) and therefore 2) probably make testing the feature I'd like to target for 5.0.0 from comment:1 not testable in insight. If there are no objections, I'd push this ticket to 5.0.1 or similar, and then test a cancel workflow from the CLI to see if the background importing continues as advertised.
comment:5 Changed 11 years ago by jamoore
- Owner changed from jamoore to jburel
Handling the CLI info under https://trac.openmicroscopy.org.uk/ome/ticket/11932#comment:2 and pushing this for UX/GUI investigation.
comment:6 Changed 11 years ago by jamoore
- Milestone changed from 5.0.0 to 5.0.1
- Version changed from 5.0.0-beta2-RC3 to 5.0.0-rc1
comment:7 Changed 10 years ago by jburel
Issues noticed while testing the CLI in place import during the road trip. Cancelling scanning is something we have to address for such files. (cf. North America report)
Nothing we can do for 5.0.1, Pushing to 5.0.2, so we start the discussion asap.
comment:8 Changed 10 years ago by jburel
- Milestone changed from 5.0.1 to 5.0.2
comment:9 Changed 10 years ago by jburel
- Owner jburel deleted
Pushing, nothing we can do for 5.0.2 since we cannot cancel during the scanning phase.
comment:10 Changed 10 years ago by jburel
ticket linked to https://trello.com/c/kTT3vVys/48-import-tng
comment:11 Changed 10 years ago by jburel
- Milestone changed from 5.0.2 to 5.0.4
comment:12 Changed 10 years ago by jamoore
- Milestone changed from 5.1.0-m4 to 5.1.1
comment:13 Changed 9 years ago by jamoore
- Component changed from Import to Client
Anything to be done here for 5.1.1?
comment:14 Changed 9 years ago by pwalczysko
The behaviour did not change here as checked today with trout merge.
comment:15 Changed 9 years ago by jburel
This is not only limited to "plate"
"scanning" cannot be broken, i.e. BF tries to find out the files composing the image. Option:
- break Importcandidates
- Upload w/o scanning and do the scanning server side.
No realistic to have that implemented for 5.1.1
comment:16 Changed 9 years ago by jburel
- Milestone changed from 5.1.1 to 5.1.2
Discussed with Josh today, moving to 5.1.2
comment:17 Changed 9 years ago by jamoore
Melissa: specifically with the thought that we could make some progress on the callback/scanning side of things in BF.
comment:18 Changed 9 years ago by jamoore
- Owner set to jamoore
I'll look into what such an API could look like with an eye on keeping it as non-invasive as possible.
comment:19 Changed 9 years ago by jamoore
- Milestone changed from 5.1.2 to 5.1.3
Started work on the API, but obviously nothing for 5.1.2. Pushing.
comment:20 Changed 9 years ago by jamoore
- Milestone changed from 5.1.3 to 5.2.0
Requires new API; pushing.
comment:21 Changed 9 years ago by jamoore
https://github.com/bitronix/btm/pull/46/files#diff-5997179544172346b7113a96958610eeR1 contains a possibly interesting InterruptibleLockedRandomAccessFile class.
comment:22 Changed 9 years ago by jamoore
- Milestone changed from 5.2.0 to OMERO-5.2.0
Splitting due to milestone decoupling.
comment:23 Changed 9 years ago by jamoore
- Milestone changed from OMERO-5.2.0 to B-F-5.2.0
comment:24 Changed 9 years ago by jburel
- Milestone changed from B-F-5.2.0 to OME-Files
Before I forget, one of the major reasons for having this properly, was that Jason suggests an important metric (if not *the* metric) is: how much faster is FS to allow me to close my client for a particular import. I.e. if the server is off working, I don't have to care.