ShareI does not have membersCounter

[atarkowska]

Could be possible to have a number of members in ShareI.

[jmoore]

Ola, do you just mean a method to return that, or as a field on Share?

[atarkowska]

I mean field

[jmoore]

Ola, would a SessionExperimenterMap solve this problem for you? This may be the cleanest way to model the interaction. It would also solve a performance problem in getMemberShares()

[atarkowska]

sounds good to me, thx

[jmoore]

r3915 contains a new table ShareMember. It is not yet used, but my hope is that we can prevent users who want to play with RC1 from having to re-create their databases.

[jmoore]

r3940

The original request was for a member count on shares. Since there was also a performance issue (linear scan over the binary data in the shares) for ShareStore.getShares(long, boolean, boolean), it made sense to add a link between shares and experimenters.

In r3915, the ShareMember type was added to do the linking of shares and members
outside of the ShareData object and in a table. (The fact that this
does not count guests will need to be handled in another way if desired)

However, I didn't add Share.memberLinks (the bidirectional relationship) in order to keep changes minimal in case this is not the proper solution. For the moment, this means that counts won't come with the shares, but must be retrieved in a separate call:

   Map<Long, Long> getMemberCount(Set<Long> shareIds);

A similar method was added for comment counts.

Both of these methods return the proper value for admins, owners, and share members, and throw a ValidationException otherwise.