Task #12011 (closed)
Bug: Delete Dataset with 2-parent-image
Reported by: | wmoore | Owned by: | mtbcarroll |
---|---|---|---|
Priority: | critical | Milestone: | 5.1.0-m3 |
Component: | Services | Version: | n.a. |
Keywords: | n.a. | Cc: | java@…, pwalczysko, hflynn, drussell-x |
Resources: | n.a. | Referenced By: | n.a. |
References: | n.a. | Remaining Time: | n.a. |
Sprint: | n.a. |
Description
If you have a Dataset, containing an Image that is also in another Dataset, then you can't delete the Dataset or move to another group.
Clients don't give you any useful message or suggested workaround.
Existing test for this is in /components/tools/OmeroPy/test/gatewaytest/test_chgrp.py .
@pytest.mark.xfail(reason="ticket 11610") def testTwoDatasetsChgrpToProject(gatewaywrapper):
Change History (22)
comment:1 Changed 10 years ago by jamoore
- Cc java@… added
- Owner jamoore deleted
- Priority changed from major to critical
comment:2 Changed 10 years ago by mtbcarroll
- Owner set to mtbcarroll
comment:3 Changed 10 years ago by mtbcarroll
- Resolution set to fixed
- Status changed from new to closed
comment:4 Changed 10 years ago by jamoore
- Milestone changed from 5.0.1 to 5.0.2
- Resolution fixed deleted
- Status changed from closed to reopened
Re-opening for client investigation of the message until this can be fixed further. See PR 2180 for status update.
comment:5 Changed 10 years ago by jamoore
- Owner changed from mtbcarroll to ux@…
- Status changed from reopened to accepted
comment:6 Changed 10 years ago by mtbcarroll
The above PR has some good integration test work by Colin once this ticket gets a server-side fix.
comment:7 Changed 10 years ago by jburel
- Owner changed from ux@… to wmoore
work done by Dominik in insight see https://github.com/openmicroscopy/openmicroscopy/pull/2160
Passing it to Will.
comment:8 Changed 10 years ago by dlindner
Just checked again, unfortunately PR 2160 does not cover the deletion of Datasets, just the explicit deletion of images linked to multiple Datasets.
comment:9 Changed 10 years ago by wmoore
You mean deleting a Dataset that is in more that one Project?
If you meant deleting a Dataset containing images that are in more than one Dataset, this should be OK, since images will not be deleted.
comment:10 Changed 10 years ago by dlindner
Currently deletion of a Dataset containing images which are linked to other Datasets, fails (without further explanation to the user). What should actually happen in this case: Deletion of a Dataset which contains this kind of images but also images which are not part of other Datasets?
comment:11 Changed 10 years ago by wmoore
If you delete a Dataset, any images that are ONLY in that Dataset should be deleted. Any images that are also in another Dataset should simply remain in that Dataset. But we don't need a warning in either case, since an image wouldn't get deleted accidentally. So the warning PR at https://github.com/openmicroscopy/openmicroscopy/pull/2160 doesn't have anything to do with this ticket. Probably JM put the comment about that PR on the wrong ticket?
comment:12 Changed 10 years ago by dlindner
Ok, sorry, was my fault, I thought this issue is related to PR 2160. I'll fix this in Insight.
comment:13 Changed 10 years ago by wmoore
- Owner changed from wmoore to jamoore
I think this got passed to me accidentally.
comment:14 Changed 10 years ago by jamoore
- Cc pwalczysko added
- Milestone changed from 5.0.2 to 5.0.3
I don't see us able to do something safely for this for 5.0.2 after all of Colin's and Mark's attempts at coming up with something.
Pushing to 5.0.3 and added under "Limitations" under the 5.0.2 testing card.
comment:15 Changed 10 years ago by hflynn
- Cc hflynn added
Adding myself to the CC list so I have a reminder to remove this from the limitations page once it is fixed.
comment:16 Changed 10 years ago by mtbcarroll
- Cc drussell-x added
comment:17 Changed 10 years ago by jamoore
- Owner changed from jamoore to mtbc
comment:18 Changed 10 years ago by jamoore
- Owner changed from mtbc to mtbcarroll
comment:19 Changed 10 years ago by jburel
- Milestone changed from 5.1.0-m3 to 5.1.0-m4
comment:20 Changed 9 years ago by mtbcarroll
- Milestone changed from 5.1.0-m4 to 5.1.0-m3
comment:21 Changed 9 years ago by mtbcarroll
- Resolution set to fixed
- Status changed from accepted to closed
Now fixed by https://github.com/openmicroscopy/openmicroscopy/pull/3228.
comment:22 Changed 9 years ago by drussell-x
Probably worth mentioning that PR #3141 addresses this new functionality on the client side. E.g. if dataset1 and dataset2 both contain the same image are are both visible and that image is chgrp'd or deleted, then it will correctly be removed from both locations.
Fixed by http://github.com/openmicroscopy/openmicroscopy/pull/2180.