Notice: In order to edit this ticket you need to be either: a Product Owner, The owner or the reporter of the ticket, or, in case of a Task not yet assigned, a team_member"

Task #12021 (accepted)

Opened 6 years ago

Last modified 4 years ago

Bug: logback timeout for import logs too long (30 min)

Reported by: jamoore Owned by: cblackburn
Priority: major Milestone: Unscheduled
Component: Services Version: 5.0.0
Keywords: n.a. Cc: java@…
Resources: n.a. Referenced By: n.a.
References: n.a. Remaining Time: n.a.
Sprint: n.a.

Description

Internal reference: https://trello.com/c/P4wOlFcd/86-close-sifted-logs
See also: #12012

Each imported fileset opens a new log file of the form:

$ManagedRepo/$User/$yearmonth/$day/$timestamp.log

These files are only cleaned up on the *next* import after 30 minutes. This can run the server out of file handles.

In newer version of logback, this value is configurable.

Change History (11)

comment:1 Changed 6 years ago by cblackburn

  • Owner set to cblackburn
  • Status changed from new to accepted

comment:2 Changed 6 years ago by jamoore

This still planned for 5.0.1

comment:3 Changed 6 years ago by cblackburn

Is that a question? If so I'd say it's not straightforward given the logback issue. If it's a statement then I'd say the same but it will involve us hacking our own version of the sifting appender at the very least.

comment:4 Changed 6 years ago by jamoore

Guess we need to summarize the state of things with your latest PRs. If there's a chance of files hanging around for 30 minutes and if there's a way we can prevent that without a week of work, it'd probably be a good thing. If not, let's push to 5.0.2 and hope for a logback release.

comment:5 Changed 6 years ago by cblackburn

  • Milestone changed from 5.0.1 to 5.0.2

Although logback has been updated this ticket is far from resolved due to existing limitations in SiftingAppenders. I'm not what the best way to move forward is at the moment but certainly pushing to 5.0.2 for now.

comment:6 Changed 6 years ago by jamoore

Does this need to be pushed again?

comment:7 Changed 6 years ago by jamoore

  • Milestone changed from 5.0.2 to 5.0.3

Short summary from chat: yes.

comment:8 Changed 5 years ago by cblackburn

  • Milestone changed from 5.0.3 to 5.1.0

Bumped to 5.1 as per Trello card.

comment:9 Changed 5 years ago by cblackburn

  • Milestone changed from 5.1.0 to 5.x
  • Priority changed from critical to major

The limitations on SiftingAppenders are still there, ie http://jira.qos.ch/browse/LOGBACK-940?page=com.atlassian.jira.plugin.system.issuetabpanels:changehistory-tabpanel so pushing this ticket to 5.x until there is some movement on that issue or some other solution presents itself. Given this is in production use and there haven't been any bug reports due to open log files I'm not convinced it should be listed as critical either so downgrading a little.

comment:10 Changed 5 years ago by mtbcarroll

There may be some interaction with this issue if we start to zip the log files.

comment:11 Changed 4 years ago by jamoore

  • Milestone changed from 5.x to Unscheduled
Note: See TracTickets for help on using tickets. You may also have a look at Agilo extensions to the ticket.

1.3.13-PRO © 2008-2011 Agilo Software all rights reserved (this page was served in: 0.150772 sec.)

We're Hiring!