Task #12117 (closed)
Bug: PlaneDeltaT in LEI showinf
| Reported by: | wmoore | Owned by: | mlinkert |
|---|---|---|---|
| Priority: | minor | Milestone: | 5.1.0 |
| Component: | Bio-Formats | Version: | n.a. |
| Keywords: | n.a. | Cc: | ajpatterson, rleigh |
| Resources: | n.a. | Referenced By: | n.a. |
| References: | n.a. | Remaining Time: | 0.0d |
| Sprint: | n.a. |
Description
With this difference in schemas:
-<OME xmlns="http://www.openmicroscopy.org/Schemas/OME/2012-06" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://www.openmicroscopy.org/Schemas/OME/2012-06 https://raw.github.com/openmicroscopy/openmicroscopy/schema-2012-06/components/specification/InProgress/ome.xsd"> +<OME xmlns="http://www.openmicroscopy.org/Schemas/OME/2013-06" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://www.openmicroscopy.org/Schemas/OME/2013-06 http://www.openmicroscopy.org/Schemas/OME/2013-06/ome.xsd">
I'm seeing some 'random' PlaneDeltaT differences in Martin's LEI sample-files.lei.
Most of the values have not changed, so I just wondered why we are getting some different ones and if the "new" values are now correct?
E.g.
@@ -157,8 +157,8 @@
<Plane DeltaT="119.953" TheC="1" TheT="0" TheZ="45"/>
<Plane DeltaT="122.625" TheC="0" TheT="0" TheZ="46"/>
<Plane DeltaT="122.625" TheC="1" TheT="0" TheZ="46"/>
- <Plane DeltaT="125.281" TheC="0" TheT="0" TheZ="47"/>
- <Plane DeltaT="125.281" TheC="1" TheT="0" TheZ="47"/>
+ <Plane DeltaT="126.118" TheC="0" TheT="0" TheZ="47"/>
+ <Plane DeltaT="126.118" TheC="1" TheT="0" TheZ="47"/>
<Plane DeltaT="127.953" TheC="0" TheT="0" TheZ="48"/>
<Plane DeltaT="127.953" TheC="1" TheT="0" TheZ="48"/>
<Plane DeltaT="130.625" TheC="0" TheT="0" TheZ="49"/>
and
@@ -248,12 +248,12 @@
<Plane DeltaT="3.188" TheC="0" TheT="8" TheZ="0"/>
<Plane DeltaT="3.657" TheC="0" TheT="9" TheZ="0"/>
<Plane DeltaT="4.125" TheC="0" TheT="10" TheZ="0"/>
- <Plane DeltaT="4.594" TheC="0" TheT="11" TheZ="0"/>
+ <Plane DeltaT="5.152" TheC="0" TheT="11" TheZ="0"/>
<Plane DeltaT="5.063" TheC="0" TheT="12" TheZ="0"/>
<Plane DeltaT="5.532" TheC="0" TheT="13" TheZ="0"/>
<Plane DeltaT="5.891" TheC="0" TheT="14" TheZ="0"/>
<Plane DeltaT="6.25" TheC="0" TheT="15" TheZ="0"/>
- <Plane DeltaT="6.61" TheC="0" TheT="16" TheZ="0"/>
+ <Plane DeltaT="7.312" TheC="0" TheT="16" TheZ="0"/>
<Plane DeltaT="6.969" TheC="0" TheT="17" TheZ="0"/>
<Plane DeltaT="7.328" TheC="0" TheT="18" TheZ="0"/>
<Plane DeltaT="7.688" TheC="0" TheT="19" TheZ="0"/>
Change History (4)
comment:1 Changed 10 years ago by rleigh
- Cc ajpatterson rleigh added
comment:2 Changed 9 years ago by mlinkert
- Resolution set to fixed
- Status changed from new to closed
comment:3 Changed 9 years ago by Melissa Linkert <melissa@…>
- Remaining Time set to 0
(In [61db1c10c8aea707a4fbb42124bc15b2c34bf988/bioformats.git] on branch develop) Revert to using java.text.SimpleDateFormat? for retrieving timestamps
Millisecond parsing in Joda has different results than with
Date/SimpleDateFormat?. If the number of ms digits in the format string
exceeds the number of ms digits in the date string, then zero padding
happens on the wrong side (e.g. 93 becomes 930 instead of 093). If
the number of ms digits in the date string exceeds the number of ms
digits in the format string, then parsing fails. See
https://github.com/JodaOrg/joda-time/issues/62.
Fixes #12117.
comment:4 Changed 9 years ago by Melissa Linkert <melissa@…>
(In [224e675e765a40c5e434d4cc249d54ba8d106cd9/bioformats.git] on branch develop) Leica: correct variable-length timestamps
Fixes #12117. Joda does not deal with variable-length millisecond
values, so this parses the milliseconds separately.
The old timestamps were correct; this difference was caused by the introduction of Joda for timestamp parsing. PR opened which should fix it: https://github.com/openmicroscopy/bioformats/pull/1508